Re: [quicwg/base-drafts] Recovery release notes for draft 20 (#2625)

Jana Iyengar <notifications@github.com> Thu, 18 April 2019 21:38 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C080C12037E for <quic-issues@ietfa.amsl.com>; Thu, 18 Apr 2019 14:38:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.001
X-Spam-Level:
X-Spam-Status: No, score=-8.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AlT6Q2XJWOoA for <quic-issues@ietfa.amsl.com>; Thu, 18 Apr 2019 14:38:51 -0700 (PDT)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AA43612040A for <quic-issues@ietf.org>; Thu, 18 Apr 2019 14:38:51 -0700 (PDT)
Date: Thu, 18 Apr 2019 14:38:50 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1555623530; bh=IU7DM1nCcwO0gLjQ3odXDhjeJ5g8jID8ZVzqTyGiQVc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=hLmJtYh0lMrgl7Uz+79rWVdh4wUFR1o47sFDwOXzf8WnX34RneSpr3vDEKOrZ8WrK kt9ufYQ1qEZaNbwzzTr721VLWCilIr2NTbNZg8esmW7B9ksai4EPxQmaGNurfLQaQK z2XBCRokZOncOacoeWTpUKp/lc9uf4utGwpiFQbA=
From: Jana Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK7UBAYFNZ3GR3X6DW52YYQOVEVBNHHBTXSSMQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2625/review/228518335@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2625@github.com>
References: <quicwg/base-drafts/pull/2625@github.com>
Subject: Re: [quicwg/base-drafts] Recovery release notes for draft 20 (#2625)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cb8ee6aa6689_7e4f3f88c04cd960378058"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/S7nbizwPJVIQpjV5h6BCcQoCixg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Apr 2019 21:38:54 -0000

janaiyengar commented on this pull request.



> @@ -1500,6 +1500,17 @@ are detected lost.
 Issue and pull request numbers are listed with a leading octothorp.
 
 ## Since draft-ietf-quic-recovery-19
+
+- Send a PING if the PTO timer fires and there's nothing to send (#2624)
+- Set loss delay to at least kGranularity (#2617)
+- Merge application limited and sending after idle sections. Always limit
+  burst size instead of requiring resetting CWND to initial CWND after
+  idle (#2605)
+- Rewrite RTT estimation, allow RTT samples where a newly acked packet is
+  ack-eliciting, but the largest_acked is not (#2592)

```suggestion
  ack-eliciting but the largest_acked is not (#2592)
```

> @@ -1500,6 +1500,17 @@ are detected lost.
 Issue and pull request numbers are listed with a leading octothorp.
 
 ## Since draft-ietf-quic-recovery-19
+
+- Send a PING if the PTO timer fires and there's nothing to send (#2624)
+- Set loss delay to at least kGranularity (#2617)
+- Merge application limited and sending after idle sections. Always limit
+  burst size instead of requiring resetting CWND to initial CWND after
+  idle (#2605)
+- Rewrite RTT estimation, allow RTT samples where a newly acked packet is
+  ack-eliciting, but the largest_acked is not (#2592)
+- No longer arm the handshake timer if there is no handshake data (#2590)

```suggestion
- Don't arm the handshake timer if there is no handshake data (#2590)
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2625#pullrequestreview-228518335