IETF Logo Mail Archive

Re: [quicwg/base-drafts] Persistent Congestion Time Threshold (#2365)

Nick Banks <notifications@github.com> Wed, 23 January 2019 21:31 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 07FC2130F1B for <quic-issues@ietfa.amsl.com>; Wed, 23 Jan 2019 13:31:32 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.935
X-Spam-Level:
X-Spam-Status: No, score=-10.935 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NsWovZR8mIsQ for <quic-issues@ietfa.amsl.com>; Wed, 23 Jan 2019 13:31:30 -0800 (PST)
Received: from out-14.smtp.github.com (out-14.smtp.github.com [192.30.254.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4921F124BE5 for <quic-issues@ietf.org>; Wed, 23 Jan 2019 13:31:30 -0800 (PST)
Date: Wed, 23 Jan 2019 13:31:29 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1548279089; bh=lwuWurNZuyxh+0WJF+3eghvBUpVLE5mH44Gqbi+LYKE=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=mM8d1BWQBDyba3QkDiJM4tw28w/+ikOm3O2hJQ6qlON9kW/ht/hqP8BWnVlzaKnmZ xDd8fsiF6tLBCLiIVzBMmi6vmh+ds5yBNxCTrhH41qbH3U4IQqjY0eUl7q3tsFP0wW LIJ+ioxb0uJRUD1bz/B9ggDmYRRxQZuFZ+vF3hds=
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2b08f097e1c975ebac0ce75317bc99b0a470f98692cf0000000118609f3192a169ce17fab1f6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2365/review/195753862@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2365@github.com>
References: <quicwg/base-drafts/pull/2365@github.com>
Subject: Re: [quicwg/base-drafts] Persistent Congestion Time Threshold (#2365)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c48dd31aca39_1d323f8ae66d45c4152078"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/S91Ksh2yPO7sXpwojUoWoUv01o8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Jan 2019 21:31:32 -0000

nibanks commented on this pull request.



> @@ -1132,6 +1144,8 @@ increases bytes_in_flight.
 
 ~~~
    OnPacketSentCC(bytes_sent):
+     if (bytes_in_flight == 0):

That doesn't quite work. What if the first packet isn't ack_eliciting but the second is? The first would still increment the counter, so when the second comes in it wouldn't be 0 any more.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2365#discussion_r250379912

v2.23.0 | Report a Bug | By Email