IETF Logo Mail Archive

Re: [quicwg/base-drafts] Server's preferred address (#1251)

Martin Thomson <notifications@github.com> Tue, 08 May 2018 22:27 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B499F12EAE3 for <quic-issues@ietfa.amsl.com>; Tue, 8 May 2018 15:27:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.008
X-Spam-Level:
X-Spam-Status: No, score=-8.008 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WJfOevpqiDwp for <quic-issues@ietfa.amsl.com>; Tue, 8 May 2018 15:27:08 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0EE5C12D7EC for <quic-issues@ietf.org>; Tue, 8 May 2018 15:27:08 -0700 (PDT)
Date: Tue, 08 May 2018 15:27:07 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1525818427; bh=PoV+UE5no2L8LQ1nQb6n64E2eOptdF4UqhIafrVjkcU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=UOk3wxUlD4jVfzGJpIBfSvu6WsuqIgo6pGx2cAOJxJpOEeAng+2FN8vbUFGZft0hr 39SFstfwinDb5RtNqGZq3FWUTeybPea3y3QlZvqR5EHirFkOwTwTEsAidbHAxRBI+I /meZTIqkCHqcDS9uox/mzK0981J21Bv//1Y6YjdA=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab414fa80f077c4c5236609e4a10038e111b5a39ee92cf000000011709e63b92a169ce126c34a9@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1251/review/118555754@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1251@github.com>
References: <quicwg/base-drafts/pull/1251@github.com>
Subject: Re: [quicwg/base-drafts] Server's preferred address (#1251)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5af2243b572f3_50092b1779746f60380b4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/S9Mx-hR5aKPI84VzX6Vd-PIR2rQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 May 2018 22:27:10 -0000

martinthomson commented on this pull request.



> @@ -1150,6 +1151,14 @@ language from Section 3 of {{!I-D.ietf-tls-tls13}}.
       };
       TransportParameter parameters<22..2^16-1>;
    } TransportParameters;
+
+   struct {
+     enum { IPv4(4), IPv6(6), (15)} ipVersion;

unbalanced space within curlies

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1251#pullrequestreview-118555754

v2.23.0 | Report a Bug | By Email