Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1])
 by ietfa.amsl.com (Postfix) with ESMTP id 6D9C23A07BE
 for <quic-issues@ietfa.amsl.com>; Tue,  2 Jun 2020 03:13:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.983
X-Spam-Level: 
X-Spam-Status: No, score=-0.983 tagged_above=-999 required=5
 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1,
 PDS_BTC_ID=0.5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key)
 header.d=github.com
Received: from mail.ietf.org ([4.31.198.44])
 by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id UBT-0o54drcf for <quic-issues@ietfa.amsl.com>;
 Tue,  2 Jun 2020 03:13:48 -0700 (PDT)
Received: from out-23.smtp.github.com (out-23.smtp.github.com [192.30.252.206])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by ietfa.amsl.com (Postfix) with ESMTPS id 3574C3A07B1
 for <quic-issues@ietf.org>; Tue,  2 Jun 2020 03:13:48 -0700 (PDT)
Received: from github-lowworker-e8b54ca.ac4-iad.github.net
 (github-lowworker-e8b54ca.ac4-iad.github.net [10.52.23.39])
 by smtp.github.com (Postfix) with ESMTP id 78E0766045A
 for <quic-issues@ietf.org>; Tue,  2 Jun 2020 03:13:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com;
 s=pf2014; t=1591092827;
 bh=YxPlMzbidXGX8N0cP7CtMr7j74NW0PZrDmETMnlaInU=;
 h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID:
 List-Archive:List-Post:List-Unsubscribe:From;
 b=su4ne1PSWJ1GgLa4HfM9/NiaYYUK5hQbQcma3xbgcPFqcEAyuq9IXU8tFKrG8nheh
 1IJ0xuWpQLjp0eYVojV7KKONyinlgQHQ3oEnVwGL3fdsBiCS2kNe3fYA8UtMZ/cYQl
 HnGxBiRWVUUYGUrizvRCw20sSxILzGcNUxM5RezA=
Date: Tue, 02 Jun 2020 03:13:47 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK5R5DAYLTM6DCEMBJ544IDVXEVBNHHCK7K3HI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3712/review/422535584@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3712@github.com>
References: <quicwg/base-drafts/pull/3712@github.com>
Subject: Re: [quicwg/base-drafts] Example of ChaCha20-Poly1305 (#3712)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5ed6265b69e23_49303f975f8cd9682373e2";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/SCx4npHQVqciS9ORNk9i9OkZ-UU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG
 <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>,
 <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Jun 2020 10:13:49 -0000


----==_mimepart_5ed6265b69e23_49303f975f8cd9682373e2
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

@martinthomson commented on this pull request.



> +      73573685608597d0efcb076b0ab7a7a4
+
+ku  = HKDF-Expand-Label(server_initial_secret, "quic ku", _, 32)
+    = 1223504755036d556342ee9361d25342
+      1a826c9ecdf3c7148684b36b714881f9
+~~~
+
+The following shows the steps involved in protecting a minimal packet with an
+empty Destination Connection ID. This packet contains a single HANDSHAKE_DONE
+frame (that is, a payload of just 0x1e) and has a packet number of 0. In this
+example, a packet number of length 3 is used to avoid having to pad the payload
+of the packet; PADDING frames would be needed if the packet number is encoded
+on fewer octets.
+
+~~~
+pn                 = 0

This packet was from me reading the logs of our implementation, which sends HANDSHAKE_DONE in packet 0.  But I decided that it might be better to make this reproducible, and it wasn't THAT hard to write some JS.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3712#discussion_r433768945
----==_mimepart_5ed6265b69e23_49303f975f8cd9682373e2
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p></p>
<p><b>@martinthomson</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3712#discussion_r433768945">draft-ietf-quic-tls.md</a>:</p>
<pre style='color:#555'>&gt; +      73573685608597d0efcb076b0ab7a7a4
+
+ku  = HKDF-Expand-Label(server_initial_secret, &quot;quic ku&quot;, _, 32)
+    = 1223504755036d556342ee9361d25342
+      1a826c9ecdf3c7148684b36b714881f9
+~~~
+
+The following shows the steps involved in protecting a minimal packet with an
+empty Destination Connection ID. This packet contains a single HANDSHAKE_DONE
+frame (that is, a payload of just 0x1e) and has a packet number of 0. In this
+example, a packet number of length 3 is used to avoid having to pad the payload
+of the packet; PADDING frames would be needed if the packet number is encoded
+on fewer octets.
+
+~~~
+pn                 = 0
</pre>
<p>This packet was from me reading the logs of our implementation, which sends HANDSHAKE_DONE in packet 0.  But I decided that it might be better to make this reproducible, and it wasn't THAT hard to write some JS.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3712#discussion_r433768945">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK3TAV75CTYMWCBW5PDRUTGFXANCNFSM4NQO433Q">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK2D7XEOL3SIXNQBQ6TRUTGFXA5CNFSM4NQO4332YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODEXWDIA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3712#discussion_r433768945",
"url": "https://github.com/quicwg/base-drafts/pull/3712#discussion_r433768945",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5ed6265b69e23_49303f975f8cd9682373e2--

