Re: [quicwg/base-drafts] Don't amplify accidentally when closing (#1911)
ianswett <notifications@github.com> Thu, 25 October 2018 14:05 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E7B6A130E5A for <quic-issues@ietfa.amsl.com>; Thu, 25 Oct 2018 07:05:09 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fQrDFb8ECnAv for <quic-issues@ietfa.amsl.com>; Thu, 25 Oct 2018 07:05:08 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 583B5128A6E for <quic-issues@ietf.org>; Thu, 25 Oct 2018 07:05:07 -0700 (PDT)
Date: Thu, 25 Oct 2018 07:05:05 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540476305; bh=Zv0IOXAOOXqNZogmjb9bNC1b+fRzLERhviliqQUZvzc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=RcrXox9rMJRPWjKZ60yhMeBO58rt9JUNB1cJpZGgvpNR4Zt7KxOl2sVSHyzSCJjEq xumwh5GsBBCp9KiMHfevbGkNoHXdfJnEVTNWy8Q23CCcG6dAZZ/rgbLXNDvYVnC5Yi vARjQEjWEa+mIwjVc/KPFlk6iziue75YRvPm5Fr4=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb4ea31a745deba06b9227b7d3295c743a21e821392cf0000000117e98f9192a169ce164732a9@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1911/review/168399181@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1911@github.com>
References: <quicwg/base-drafts/pull/1911@github.com>
Subject: Re: [quicwg/base-drafts] Don't amplify accidentally when closing (#1911)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd1cd91ea9e5_19173fa1744d45b8186736e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/SERhumnq04bKDBG2O-M4EobpWPw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Oct 2018 14:05:10 -0000
ianswett commented on this pull request.
> @@ -2228,6 +2228,12 @@ Note:
control, which are not expected to be relevant for a closed connection.
Retransmitting the final packet requires less state.
+New packets from unverified addresses could be used to create an amplification
+attack (see {{address-validation}}). To avoid this, endpoints MUST either limit
+transmission of closing frames to validated addresses - which implies retaining
I'd remove the "- which implies retraining knowledge of validated addresses -" because it makes the sentence a bit awkward and I think it's unnecessary.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1911#pullrequestreview-168399181
- Re: [quicwg/base-drafts] Don't amplify accidental… Martin Thomson
- [quicwg/base-drafts] Don't amplify accidentally w… Martin Thomson
- Re: [quicwg/base-drafts] Don't amplify accidental… Marten Seemann
- Re: [quicwg/base-drafts] Don't amplify accidental… ianswett
- Re: [quicwg/base-drafts] Don't amplify accidental… Martin Thomson
- Re: [quicwg/base-drafts] Don't amplify accidental… Martin Thomson
- Re: [quicwg/base-drafts] Don't amplify accidental… ianswett