Date: Wed, 06 Feb 2019 17:08:33 -0800
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4ab82206da60ae720855ab715eefde190e9e00696d692cf000000011873471192a169ce183c6fbc@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2417/review/200883927@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2417@github.com>
References: <quicwg/base-drafts/pull/2417@github.com>
Subject: Re: [quicwg/base-drafts] update the pseudo code to include packet
 number spaces (#2417)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5c5b8511120bb_3fd33f9bf80d45c083640";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/SGxGVm_RBT2KVEJz1MJjFTjki38>


----==_mimepart_5c5b8511120bb_3fd33f9bf80d45c083640
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

marten-seemann commented on this pull request.



> @@ -903,20 +915,22 @@ to OnPacketSent are described in detail above in {{sent-packets-fields}}.
 Pseudocode for OnPacketSent follows:
 
 ~~~
- OnPacketSent(packet_number, ack_eliciting, in_flight,
-              is_crypto_packet, sent_bytes):
-   largest_sent_packet = packet_number
-   sent_packets[packet_number].packet_number = packet_number
-   sent_packets[packet_number].time_sent = now
-   sent_packets[packet_number].ack_eliciting = ack_eliciting
-   sent_packets[packet_number].in_flight = in_flight
+ OnPacketSent(packet_number, pn_space, ack_eliciting,

Done.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2417#discussion_r254515283
----==_mimepart_5c5b8511120bb_3fd33f9bf80d45c083640
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@marten-seemann</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2417#discussion_r254515283">draft-ietf-quic-recovery.md</a>:</p>
<pre style='color:#555'>&gt; @@ -903,20 +915,22 @@ to OnPacketSent are described in detail above in {{sent-packets-fields}}.
 Pseudocode for OnPacketSent follows:
 
 ~~~
- OnPacketSent(packet_number, ack_eliciting, in_flight,
-              is_crypto_packet, sent_bytes):
-   largest_sent_packet = packet_number
-   sent_packets[packet_number].packet_number = packet_number
-   sent_packets[packet_number].time_sent = now
-   sent_packets[packet_number].ack_eliciting = ack_eliciting
-   sent_packets[packet_number].in_flight = in_flight
+ OnPacketSent(packet_number, pn_space, ack_eliciting,
</pre>
<p>Done.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2417#discussion_r254515283">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq5N6KqC28X4g2oFWzSVUlt5bGnpKks5vK3yRgaJpZM4aidmj">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq1-ZxOnZr4vUXQCRM6le3y_uODm_ks5vK3yRgaJpZM4aidmj.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@marten-seemann commented on #2417"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/2417#discussion_r254515283"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2417#discussion_r254515283",
"url": "https://github.com/quicwg/base-drafts/pull/2417#discussion_r254515283",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5c5b8511120bb_3fd33f9bf80d45c083640--