IETF Logo Mail Archive

Re: [quicwg/base-drafts] Pad rather than shift the header protection offset (#2030)

Kazuho Oku <notifications@github.com> Wed, 21 November 2018 10:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 9771E12958B for <quic-issues@ietfa.amsl.com>; Wed, 21 Nov 2018 02:40:14 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ruQbODqkdCLS for <quic-issues@ietfa.amsl.com>; Wed, 21 Nov 2018 02:40:12 -0800 (PST)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id ACA9A12F1A2 for <quic-issues@ietf.org>; Wed, 21 Nov 2018 02:40:12 -0800 (PST)
Date: Wed, 21 Nov 2018 02:40:11 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1542796811; bh=2uoBhujSWNJp94b7tntCmxl//vIsooqmf8k2n1zwzkc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=dlH5YvCEo/3hrtVUhwn2p4MSzINXI3IHAXy7LqYrMYsAQgbvRR2odmVPSO6PCrdBW pxC9GhmeAU/5KvF44fI58wt4FoEEerNctaeGROqBR9Lar32e1M5Mbd6Hr+eq2XvFVn X50rLCaZJC9OnpReOLkihXqqQhGYCMjKQ0oDE5FE=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb94dcc2f776f00255bb3f0dc94778e77b12b44f392cf00000001180cf80b92a169ce16d361fa@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2030/c440617573@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2030@github.com>
References: <quicwg/base-drafts/pull/2030@github.com>
Subject: Re: [quicwg/base-drafts] Pad rather than shift the header protection offset (#2030)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bf5360b99849_6a853fb0be6d45bc4021cb"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/SIDuh6_ZJHNg8ODFWtGGSoPz6eM>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Nov 2018 10:40:15 -0000

@mikkelfj 
> the current solution because the sample location can the be determined with a single branchless min operation that cost a few machine instructions rather than stuffing padding bytes on the wire in special cases.

But the downside of the current approach is that the adjustment needs to be calculated on both the sender and the receiver. The approach in the PR requires having just one branch (that almost always turns to one side) on the sender. Therefore, I'd assume that the it not only simplifies the code but would be superior in performance as well.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2030#issuecomment-440617573

v2.23.0 | Report a Bug | By Email