Re: [quicwg/base-drafts] Simplify TLP and RTO into Probe Timeout (#2114)

[Martin Thomson <[e-mail]>]

martinthomson commented on this pull request.

Haven't reviewed, but these might help

> @@ -297,7 +297,7 @@ If a packet is lost, the QUIC transport needs to recover from that loss, such
 as by retransmitting the data, sending an updated frame, or abandoning the
 frame.  For more information, see Section 13.2 of {{QUIC-TRANSPORT}}.
 
-## Ack-based Detection
+## Ack-based Detection {#ack-loss-detection}

```suggestion
## ACK-based Detection {#ack-loss-detection}
```

>  
-* If RTO ({{rto}}) is earlier, schedule a TLP in its place. That is,
-  PTO SHOULD be scheduled for min(RTO, PTO).
+PTO = max(smoothed_rtt + 4*rttvar + max_ack_delay, kGranularity)

```suggestion
~~~
PTO = max(smoothed_rtt + 4*rttvar + max_ack_delay, kGranularity)
~~~
```

>       else:
-       // RTO.
-       if (rto_count == 0)
-         largest_sent_before_rto = largest_sent_packet
+       // PTO.
+       if (pto_count == 0)

```suggestion
       if (pto_count == 0):
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2114#pullrequestreview-183946331