IETF Logo Mail Archive

Re: [quicwg/base-drafts] ECN Counts; last fix (#4920)

Martin Thomson <notifications@github.com> Wed, 26 May 2021 01:42 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D87093A1820 for <quic-issues@ietfa.amsl.com>; Tue, 25 May 2021 18:42:38 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.179
X-Spam-Level:
X-Spam-Status: No, score=-2.179 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.698, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_BLOCKED=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IdnzS_awOE3V for <quic-issues@ietfa.amsl.com>; Tue, 25 May 2021 18:42:36 -0700 (PDT)
Received: from smtp.github.com (out-25.smtp.github.com [192.30.252.208]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 0F0BA3A181E for <quic-issues@ietf.org>; Tue, 25 May 2021 18:42:35 -0700 (PDT)
Received: from github.com (hubbernetes-node-479f63f.ash1-iad.github.net [10.56.108.79]) by smtp.github.com (Postfix) with ESMTPA id 2A9AE840D62 for <quic-issues@ietf.org>; Tue, 25 May 2021 18:42:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1621993355; bh=Hx5qovoXhtJXJB53dNHgaGSpAocmogO7qIraMJBVsLg=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Eg6kCaJKw+S18NRV9BfIjlIo18t8clJHnIfQyXVN03zbI22M5yriXwCW6VsN/Zbkf jIIOuYizwpsfH7fuJfPGDUnWOX2cGOBkXQp4v+s7xpBLvQ+kPp4yi5/UJvIErXniZs DFMY0tkEj3kv5knByAjAuHF/jfG0qGhrE5NjbB3E=
Date: Tue, 25 May 2021 18:42:35 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4W44XQZ5MR6HACO3N6XGEIXEVBNHHDLPC4VA@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4920/review/668530219@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4920@github.com>
References: <quicwg/base-drafts/pull/4920@github.com>
Subject: Re: [quicwg/base-drafts] ECN Counts; last fix (#4920)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_60ada78b27830_20d9c5bc167774"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/SO83GKYi7QGIL-84WLjaPdabR9Y>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 26 May 2021 01:42:39 -0000

@martinthomson commented on this pull request.



> @@ -5674,7 +5674,7 @@ connection error of type FRAME_ENCODING_ERROR.
 The ACK frame uses the least significant bit of the type value (that is, type
 0x03) to indicate ECN feedback and report receipt of QUIC packets with
 associated ECN codepoints of ECT(0), ECT(1), or ECN-CE in the packet's IP
-header.  ECN Counts are only present when the ACK frame type is 0x03.
+header.  The ECN Counts field is only present when the ACK frame type is 0x03.

```suggestion
header.  ECN counts are only present when the ACK frame type is 0x03.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4920#pullrequestreview-668530219

v2.23.0 | Report a Bug | By Email