Re: [quicwg/base-drafts] Migration in Security Considerations (#2427)

ianswett <notifications@github.com> Wed, 06 February 2019 10:05 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EBAE9126CC7 for <quic-issues@ietfa.amsl.com>; Wed, 6 Feb 2019 02:05:55 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -10.935
X-Spam-Level:
X-Spam-Status: No, score=-10.935 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-4.553, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id BJxwZOqt7rJ3 for <quic-issues@ietfa.amsl.com>; Wed, 6 Feb 2019 02:05:54 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5D627124D68 for <quic-issues@ietf.org>; Wed, 6 Feb 2019 02:05:54 -0800 (PST)
Date: Wed, 06 Feb 2019 02:05:53 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1549447553; bh=F5ltlOTAGFJ0dfHmHKLe/yp7n5AMeg89s5dzbN4eTsI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=PRU/VS6ce3ubi32eTuv4OU1WCR6xZiYsx2f1tywqUf9tpHG1YV2daV9fWacq7wDBk 6MqBB3jMV3CoAtP8GUgocHScE1tFcjeQNbseGATWdzlCT2DGaBf7I3Jn1XLJeyDAle cqT7NS4uSs5QaQ8wXa3ykfTVYpPWCJRz5vHZGXzs=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abb7ffc72d21bb118161574df4851ee08ff628fffd92cf000000011872738192a169ce1842e6ac@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2427/review/200493793@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2427@github.com>
References: <quicwg/base-drafts/pull/2427@github.com>
Subject: Re: [quicwg/base-drafts] Migration in Security Considerations (#2427)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c5ab18162ac1_7f553f9c878d45c4430320"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/SQSQMN6IlgfxzU2Uq6hireoNr2g>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Feb 2019 10:05:56 -0000

ianswett commented on this pull request.



> @@ -1463,6 +1463,13 @@ could pose a security risk to an incautious implementer.  An implementation MUST
 ensure that the length of a frame exactly matches the length of the fields it
 contains.
 
+Certain HTTP implementations use the client address for logging or

Can you add a sub-heading(##) for each of these considerations, like in the transport draft?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2427#pullrequestreview-200493793