IETF Logo Mail Archive

Re: [quicwg/base-drafts] Clarify conditions for disabling spin bit (#3296)

Martin Thomson <notifications@github.com> Wed, 11 December 2019 02:18 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B66D0120086 for <quic-issues@ietfa.amsl.com>; Tue, 10 Dec 2019 18:18:51 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x7zpXD0MeVNq for <quic-issues@ietfa.amsl.com>; Tue, 10 Dec 2019 18:18:50 -0800 (PST)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 54E36120059 for <quic-issues@ietf.org>; Tue, 10 Dec 2019 18:18:50 -0800 (PST)
Received: from github-lowworker-2ef7ba1.ac4-iad.github.net (github-lowworker-2ef7ba1.ac4-iad.github.net [10.52.16.66]) by smtp.github.com (Postfix) with ESMTP id 841D6A04F7 for <quic-issues@ietf.org>; Tue, 10 Dec 2019 18:18:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1576030729; bh=SRX5H9OYye3caBIJDQpziHGB83wMnB4GwemBMPbAzuo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=M8h4HgAiBoV5bLhPa7zWo7xBp1MjObWPZdnoz/30fjT5Tr2VwJCjYPfli4j2evL8E WWpdScvIF7XgikZCaioBWbbNsZe9tnOSN2PK6ac947mixmaW1TG03ZcU9QquO6qp5m uiEsttl464RvpUKTRdcJlTNKBUZqeLJayLH0BR2w=
Date: Tue, 10 Dec 2019 18:18:49 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK622M32ECPZJCZAU4V37WCITEVBNHHB746W5E@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3296/review/330264122@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3296@github.com>
References: <quicwg/base-drafts/pull/3296@github.com>
Subject: Re: [quicwg/base-drafts] Clarify conditions for disabling spin bit (#3296)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5df05209741ab_5f273fb81accd960196384"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/SRLWPin0EJjY5olX1Mou3Ey0KbQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 11 Dec 2019 02:18:52 -0000

martinthomson commented on this pull request.



> @@ -4380,12 +4380,10 @@ support the spin bit MUST implement it as specified in this section.
 Each endpoint unilaterally decides if the spin bit is enabled or disabled for a
 connection. Implementations MUST allow administrators of clients and servers
 to disable the spin bit either globally or on a per-connection basis. Even when
-the spin bit is not disabled by the administrator, implementations MUST disable
-the spin bit for a given connection with a certain likelihood. The random
-selection process SHOULD be designed such that on average the spin bit is
-disabled for at least one eighth of network paths. The selection process
-performed at the beginning of the connection SHOULD be applied for all paths
-used by the connection.

Yeah, it seems to be duplicative as the text now talks about paths rather than connections.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3296#discussion_r356374911

v2.23.0 | Report a Bug | By Email