Re: [quicwg/base-drafts] lost_pn can no longer be negative (#2621)

Marten Seemann <notifications@github.com> Mon, 15 April 2019 15:40 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2FF461203A1 for <quic-issues@ietfa.amsl.com>; Mon, 15 Apr 2019 08:40:50 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.383
X-Spam-Level:
X-Spam-Status: No, score=-6.383 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Q58cFrA9IbHt for <quic-issues@ietfa.amsl.com>; Mon, 15 Apr 2019 08:40:48 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 33F3A1203DC for <quic-issues@ietf.org>; Mon, 15 Apr 2019 08:40:48 -0700 (PDT)
Date: Mon, 15 Apr 2019 08:40:47 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1555342847; bh=5nYn8wABuQ0AMcoWqrb3qzMOxnCfd6Vdpb5uFysWnz0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=oOYr4euBZP3TOnN/XEnPNFmcWGsKjQbavXOtWkZfyaaxubRTtbySlQ3r3SwdVLYxc Igys7MuHFk3EOMn77cqAgOC1SRPWbH9epX4PHA+Tje/r2ekyGUh/sIkljBa4xT1ttv LzxtFggMIoHjQAAzVIZq2DegWOrI5aatvC90SwTg=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab44437295e1a0e4b79ecafbc5043974e08cbda48a92cebac1d87f92a169ce19d467b3@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2621/review/226726973@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2621@github.com>
References: <quicwg/base-drafts/pull/2621@github.com>
Subject: Re: [quicwg/base-drafts] lost_pn can no longer be negative (#2621)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cb4a5ff6e4b5_73a83fb8e6cd45b83108f"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/SZHNygamELoFwzRwAtETCNeSt78>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Apr 2019 15:40:50 -0000

marten-seemann requested changes on this pull request.

You'll also have to change the first line of `OnAckReceived(ack, pn_space)`.

I'm wondering if it wouldn't be easier to initialize it to -1 instead.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2621#pullrequestreview-226726973