Re: [quicwg/base-drafts] Remove the explicit packet number gap in favor of one computed (#496)
janaiyengar <notifications@github.com> Thu, 04 May 2017 01:15 UTC
Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 245AB12953F for <quic-issues@ietfa.amsl.com>; Wed, 3 May 2017 18:15:27 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.617
X-Spam-Level:
X-Spam-Status: No, score=-0.617 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VeRIF2tt8lbD for <quic-issues@ietfa.amsl.com>; Wed, 3 May 2017 18:15:25 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 8A120127058 for <quic-issues@ietf.org>; Wed, 3 May 2017 18:15:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=ofapVz2yehndKZf88sDMaBY62Hc=; b=tSm7kswiC58jMu/s uf4Cwxa8n3DBtV0zosxGdrFTzVhWSpOeJPqqeQNfGWyHGI+SdLFMcMJSIJRlon6m 52gBfCn44QlDiUmgmVI7HvIKJMUMmK/nKCPFHvvJ3jvI6Q5tOr2OlVFSAM5bhHdq LUuOl83rPkCHwOpMT7q9xFskTeM=
Received: by filter0423p1mdw1.sendgrid.net with SMTP id filter0423p1mdw1-29828-590A8073-34 2017-05-04 01:14:27.390219542 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0006p1iad1.sendgrid.net (SG) with ESMTP id YKBdX-tCQu-Y5sGoiSbdaQ for <quic-issues@ietf.org>; Thu, 04 May 2017 01:14:27.343 +0000 (UTC)
Date: Wed, 03 May 2017 18:14:27 -0700
From: janaiyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab75b69b018bc8b5c1ffa288dca08997edc578d82292cf000000011522427392a169ce0d7957f1@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/496/review/36173931@github.com>
In-Reply-To: <quicwg/base-drafts/pull/496@github.com>
References: <quicwg/base-drafts/pull/496@github.com>
Subject: Re: [quicwg/base-drafts] Remove the explicit packet number gap in favor of one computed (#496)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_590a80733709b_7d73fe695eb1c3c15663e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: janaiyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3bJ15wT2+VQBVc11uWQKrGhu0mmRvcxdsjJv kk5hkHUEgwWoquImlRVyhA5eimGZ1yLpupSnCVhivMBy64lkOcTxg+fbe3o7mHuBhxuE5OIyrSL8fr UNpnKXm+Fc8pbealssamjj0OPKH88IQjMnoSZUpMwsrLpMJVPNv7QWUstUz4g8HXOUL3AAUUdym6T3 4=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/S_utqc8t0jOGY28duSINEdvY4-I>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 04 May 2017 01:15:27 -0000
janaiyengar commented on this pull request. > @@ -1296,6 +1291,22 @@ connection ID, it should expect packets on the new connection ID to start at 18. A packet with the new connection ID and a packet number of 17 is discarded as being in error. +#### Packet Number Gap + +In order to avoid linkage, the packet number gap MUST be externally +indistinguishable from random. The packet number gap for a connection +ID with sequence number is computed by encoding the sequence number +as a 32-bit integer in big-endian format, and then computing: + +~~~ +Gap = HKDF-Expand-Label(packet_number_secret, + "QUIC packet sequence gap", sequence, 4) Hm -- good point martinthomson@ -- I hadn't thought about that. Is it adequate to do some sort of simple hash here then? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/496#discussion_r114686560
- [quicwg/base-drafts] Remove the explicit packet n… ekr
- Re: [quicwg/base-drafts] Remove the explicit pack… ekr
- Re: [quicwg/base-drafts] Remove the explicit pack… Martin Thomson
- Re: [quicwg/base-drafts] Remove the explicit pack… ekr
- Re: [quicwg/base-drafts] Remove the explicit pack… ekr
- Re: [quicwg/base-drafts] Remove the explicit pack… janaiyengar
- Re: [quicwg/base-drafts] Remove the explicit pack… janaiyengar
- Re: [quicwg/base-drafts] Remove the explicit pack… Martin Thomson
- Re: [quicwg/base-drafts] Remove the explicit pack… ekr
- Re: [quicwg/base-drafts] Remove the explicit pack… janaiyengar
- Re: [quicwg/base-drafts] Remove the explicit pack… Martin Thomson
- Re: [quicwg/base-drafts] Remove the explicit pack… janaiyengar
- Re: [quicwg/base-drafts] Remove the explicit pack… Martin Thomson
- Re: [quicwg/base-drafts] Remove the explicit pack… ekr
- Re: [quicwg/base-drafts] Remove the explicit pack… janaiyengar
- Re: [quicwg/base-drafts] Remove the explicit pack… janaiyengar
- Re: [quicwg/base-drafts] Remove the explicit pack… Martin Thomson