Re: [quicwg/base-drafts] Add OnPacketReceived to pseudocode (#3653)

Martin Thomson <notifications@github.com> Mon, 18 May 2020 00:12 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E244A3A0840 for <quic-issues@ietfa.amsl.com>; Sun, 17 May 2020 17:12:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.2
X-Spam-Level:
X-Spam-Status: No, score=-1.2 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id epDofLg4NTiR for <quic-issues@ietfa.amsl.com>; Sun, 17 May 2020 17:11:59 -0700 (PDT)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 9414B3A0916 for <quic-issues@ietf.org>; Sun, 17 May 2020 17:11:59 -0700 (PDT)
Received: from github-lowworker-d31a065.va3-iad.github.net (github-lowworker-d31a065.va3-iad.github.net [10.48.17.70]) by smtp.github.com (Postfix) with ESMTP id E50F8E0365 for <quic-issues@ietf.org>; Sun, 17 May 2020 17:11:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1589760718; bh=JN/v6z7fwzCmc/Toij750DoGfy80Pi90m6lAoatLJYo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=klD6ebeBYGum0XY5NvZkiZxyqBMhz07NXrbWvadfmiF6L/z6nbZDmGopZczLsXAVB 2HesEmUk36aSiuQvXxgalWSgRxpOMs1LWGZRbiNEM7T/t1jRDKdHmjxOf+T8YdrQjr D41eqZppdOJH+Xz8GrdSk61vvXILkubmdVvL7NsY=
Date: Sun, 17 May 2020 17:11:58 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2BUPSKVOS3ZJNCNDN4ZWZ45EVBNHHCJTOADM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3653/review/413212951@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3653@github.com>
References: <quicwg/base-drafts/pull/3653@github.com>
Subject: Re: [quicwg/base-drafts] Add OnPacketReceived to pseudocode (#3653)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ec1d2ced4551_8433fad140cd9643378a3"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/SamEa33vShlgRLuzKBq2835yFdA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 18 May 2020 00:12:01 -0000

@martinthomson approved this pull request.

A rewording suggestion; and a minor error correction.

> @@ -1142,6 +1142,21 @@ Pseudocode for OnPacketSent follows:
      SetLossDetectionTimer()
 ~~~
 
+## On Receiving a Datagram
+
+When a datagram is received, it may allow the server to send
+if the server was previously amplification limited, even if
+none of the packets in it can be processed.
+
+Pseudocode for OnDatagramReceived follows:
+
+~~~
+OnDatagramReceived(datagram):
+  // If this packet unblocks the server, arm the

```suggestion
  // If this datagram unblocks the server, arm the
```

> +When a datagram is received, it may allow the server to send
+if the server was previously amplification limited, even if
+none of the packets in it can be processed.

```suggestion
Receiving a datagram might allow the server to send additional data if the
server was previously blocked by the anti-amplification limits; see
{{before-address-validation}}. This is necessary even if none of the packets in
the datagram are successfully processed.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3653#pullrequestreview-413212951