Date: Thu, 23 Jan 2020 05:25:30 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+AFTOJK535BJNXUV734N4ZBV4G3IUVEVBNHHCCBYAVY@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3392/review/347291445@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3392@github.com>
References: <quicwg/base-drafts/pull/3392@github.com>
Subject: Re: [quicwg/base-drafts] Small clarification and one nit (recovery)
 (#3392)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5e299eca27102_5d4e3fc02c8cd9681287d7";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/ShNAIJYEyecbtSDb5_GlJg4Igrs>


----==_mimepart_5e299eca27102_5d4e3fc02c8cd9681287d7
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett commented on this pull request.



> @@ -467,14 +467,14 @@ Handshake packet number spaces, the max_ack_delay is 0, as specified in
 The PTO value MUST be set to at least kGranularity, to avoid the timer expiring
 immediately.
 
-A sender computes its PTO timer every time an ack-eliciting packet is sent.
+A sender resets its PTO timer every time an ack-eliciting packet is sent.

I think computes is more accurate in this case, because the timer may not change if another packet number space will fire earlier.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3392#pullrequestreview-347291445
----==_mimepart_5e299eca27102_5d4e3fc02c8cd9681287d7
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@ianswett</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/3392#discussion_r370113671">draft-ietf-quic-recovery.md</a>:</p>
<pre style='color:#555'>&gt; @@ -467,14 +467,14 @@ Handshake packet number spaces, the max_ack_delay is 0, as specified in
 The PTO value MUST be set to at least kGranularity, to avoid the timer expiring
 immediately.
 
-A sender computes its PTO timer every time an ack-eliciting packet is sent.
+A sender resets its PTO timer every time an ack-eliciting packet is sent.
</pre>
<p>I think computes is more accurate in this case, because the timer may not change if another packet number space will fire earlier.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/3392?email_source=notifications&amp;email_token=AFTOJK6UVP2PIS4HRZULZWTQ7GLEVA5CNFSM4KKVDEWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSZT6NI#pullrequestreview-347291445">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AFTOJK2JZYNIDGISBFNVMJLQ7GLEVANCNFSM4KKVDEWA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AFTOJK5HNRBVKSK2TMTXQVLQ7GLEVA5CNFSM4KKVDEWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSZT6NI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/3392?email_source=notifications\u0026email_token=AFTOJK6UVP2PIS4HRZULZWTQ7GLEVA5CNFSM4KKVDEWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSZT6NI#pullrequestreview-347291445",
"url": "https://github.com/quicwg/base-drafts/pull/3392?email_source=notifications\u0026email_token=AFTOJK6UVP2PIS4HRZULZWTQ7GLEVA5CNFSM4KKVDEWKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCSZT6NI#pullrequestreview-347291445",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5e299eca27102_5d4e3fc02c8cd9681287d7--