IETF Logo Mail Archive

Re: [quicwg/base-drafts] NEW_CONNECTION_ID: use sequence number for one CID only (#2096)

MikkelFJ <notifications@github.com> Tue, 04 December 2018 16:16 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 20AB1130DE2 for <quic-issues@ietfa.amsl.com>; Tue, 4 Dec 2018 08:16:36 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -9.46
X-Spam-Level:
X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1PJH_9Xp8Kmf for <quic-issues@ietfa.amsl.com>; Tue, 4 Dec 2018 08:16:34 -0800 (PST)
Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3C29312870E for <quic-issues@ietf.org>; Tue, 4 Dec 2018 08:16:34 -0800 (PST)
Date: Tue, 04 Dec 2018 08:16:33 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543940193; bh=zmPCJwrBnQm1h+bTE/LucNji06mfNeyCgdmU8kWzEOw=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=b8Wc7LhwaAW+mkotpsDQxLqWTVLBINybbpeMOAKJBaWY0aFu3PEYKV1GdZvaz2frD 006fCpY9uOYbdXSO9ecSyxPzXvAb/1jYw0t29v7Ly0FNcmtEY/p+AogZ9+9e8IgPoX WGXQ8PUWNUD+Rgaa4hJJrboWcQBMUrouuXt8T0wE=
From: MikkelFJ <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abda43cbadd781e683eb21b902d101b7441c9ba11392cf00000001181e6a6192a169ce171693ce@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2096/c444158906@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2096@github.com>
References: <quicwg/base-drafts/pull/2096@github.com>
Subject: Re: [quicwg/base-drafts] NEW_CONNECTION_ID: use sequence number for one CID only (#2096)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c06a86145ff_7e353fd377ad45b4300910"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: mikkelfj
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/SkJUIhJ9n6tWs3NSiRa-RxJBfH4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Dec 2018 16:16:36 -0000

I'm not opposed to checking - I did write range check - only that I don't see how you can conclude a sequence number is wrong based on its assumed incorrect origin.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2096#issuecomment-444158906

v2.39.1 | Report a Bug | By Email | System Status