Re: [quicwg/base-drafts] QPACK Appendix B: nameIndex (#3544)

Martin Thomson <notifications@github.com> Tue, 24 March 2020 10:36 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 1BA9E3A1210 for <quic-issues@ietfa.amsl.com>; Tue, 24 Mar 2020 03:36:24 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.008
X-Spam-Level:
X-Spam-Status: No, score=-2.008 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_16=1.092, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rsDGVLI35mz4 for <quic-issues@ietfa.amsl.com>; Tue, 24 Mar 2020 03:36:22 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D58AD3A120D for <quic-issues@ietf.org>; Tue, 24 Mar 2020 03:36:21 -0700 (PDT)
Received: from github-lowworker-c53a806.ac4-iad.github.net (github-lowworker-c53a806.ac4-iad.github.net [10.52.23.45]) by smtp.github.com (Postfix) with ESMTP id C1A2896099D for <quic-issues@ietf.org>; Tue, 24 Mar 2020 03:36:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1585046180; bh=W2irqBueLgkgHxavGiH9p4gyUi4uJnXRy7rd6RZmaq8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=tvC4cUTMnhnLvAivIEH6t77v84F062QkhGKGv1NUrCX64PxidzPjV+iFG9wcgiNW7 2WldF4oeHJtInSj0nl3HtTs+6oKqgZ9FMNhiKqzosQC85gcTj54JFdufT+mM3UgkVU z0XVc4m6pj+U973snanA3q9FF1Bi/AYK5jxArZWw=
Date: Tue, 24 Mar 2020 03:36:20 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6IKBYZ32HNFDFXWRN4QXB2JEVBNHHCF6NMAM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/3544/603160588@github.com>
In-Reply-To: <quicwg/base-drafts/issues/3544@github.com>
References: <quicwg/base-drafts/issues/3544@github.com>
Subject: Re: [quicwg/base-drafts] QPACK Appendix B: nameIndex (#3544)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e79e2a4b2398_220c3fcfb24cd968855b9"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/SkawUFgzOFWnlFJSe_DS62n9Syk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Mar 2020 10:36:24 -0000

Yikes, that original name was a little hard to follow.

It strikes me that this code could be improved by consistently choosing either Idx or Index throughout.  Though that might require some additional attention to line length if the longer (and better) option is chosen.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/3544#issuecomment-603160588