IETF Logo Mail Archive

Re: [quicwg/base-drafts] Define AreAllPacketsLost() (#3290)

ianswett <notifications@github.com> Fri, 06 December 2019 17:57 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 2EF1912006D for <quic-issues@ietfa.amsl.com>; Fri, 6 Dec 2019 09:57:09 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KDWzeW4xumko for <quic-issues@ietfa.amsl.com>; Fri, 6 Dec 2019 09:57:08 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id D0772120059 for <quic-issues@ietf.org>; Fri, 6 Dec 2019 09:57:07 -0800 (PST)
Date: Fri, 06 Dec 2019 09:57:06 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1575655026; bh=1ra7rUwTN2y1MWtlilGD+VEyW/39fmw58aVQUKywXPA=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=1+7mKCVAYPuanIwiORJDsZpylbvCp0OnhtJ/An6kTzmnAwoi12v6zk/Yqhd/7WFF3 OCTcH7mpve4GJSdxJ3PBbETdjIMsc2kImwKC/5P9nxY46jmRkMxOZK067m/HPmBrRC +KTTIXYFbWJPbCwujmGEpEXB30XTyQxAQZRg1LBI=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3Y22AEN57SGYQXIL5367EPFEVBNHHB7VVU2M@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3290/review/328363255@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3290@github.com>
References: <quicwg/base-drafts/pull/3290@github.com>
Subject: Re: [quicwg/base-drafts] Define AreAllPacketsLost() (#3290)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dea9672afff3_73d93fd0376cd968922d4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/SqXScCwb-hR1riuXv8HCUNrjrMI>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Dec 2019 17:57:09 -0000

ianswett commented on this pull request.



>       pto = smoothed_rtt + max(4 * rttvar, kGranularity) +
        max_ack_delay
      congestion_period = pto * kPersistentCongestionThreshold
      // Determine if all packets in the time period before the
      // newest lost packet, including the edges, are marked
      // lost
-     return AreAllPacketsLost(largest_lost_packet,
-                              congestion_period)
+     return congestion_period >
+       largest_lost_packet.time_sent - earliest_lost_packet.time_sent

+1 is.  

Think through the example where 0, 1 and 2 are lost.  lost_packets has length 3.  But 2 - 0 = 2, so you need to add 1.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3290#discussion_r354957810

v2.23.0 | Report a Bug | By Email