Re: [quicwg/base-drafts] editorial changes in the closing section (#2315)

Martin Thomson <notifications@github.com> Tue, 08 January 2019 07:02 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 72DBA130DD7 for <quic-issues@ietfa.amsl.com>; Mon, 7 Jan 2019 23:02:10 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.064
X-Spam-Level:
X-Spam-Status: No, score=-8.064 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LQHUjEtgtq_H for <quic-issues@ietfa.amsl.com>; Mon, 7 Jan 2019 23:02:09 -0800 (PST)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C9A101274D0 for <quic-issues@ietf.org>; Mon, 7 Jan 2019 23:02:08 -0800 (PST)
Date: Mon, 07 Jan 2019 23:02:07 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546930927; bh=XKDGU9enEzLgn3hfcZCpp/BnPoIqXoa9+6XXY8lAF4Q=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=v9rsfaIxjtQWEVV+v6P63HEcHclEOkBJWEw3tu21Qb2fdTesMRQyP38+ZDKXgUjpY ayWwIKPxM4OKJMbNyOWZRzk04cDZyeQvO1rOwG0Eh0PYNF6LuqpKDNnocIc2GqLHIn dyU5mWvyEe+nf0Z8YH8tk7uDlC6MBb9XRmMSR4HY=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab37ecbb58175e8e8286ec27d46bf9acd49463443892cf00000001184c0cef92a169ce17a59a36@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2315/review/190111960@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2315@github.com>
References: <quicwg/base-drafts/pull/2315@github.com>
Subject: Re: [quicwg/base-drafts] editorial changes in the closing section (#2315)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c344aefb7051_6a0b3f9426ed45b4279586"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/T0jS72_smMX7gpWkkb2BdZYwL2E>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Jan 2019 07:02:11 -0000

martinthomson commented on this pull request.



>  
 An endpoint enters a closing period after initiating an immediate close
 ({{immediate-close}}).  While closing, an endpoint MUST NOT send packets unless
 they contain a CONNECTION_CLOSE frame (see {{immediate-close}} for details).  An
 endpoint retains only enough information to generate a packet containing a
 CONNECTION_CLOSE frame and to identify packets as belonging to the connection.
-The connection ID and QUIC version is sufficient information to identify packets
-for a closing connection; an endpoint can discard all other connection state.
-An endpoint MAY retain packet protection keys for incoming packets to allow it
-to read and process a CONNECTION_CLOSE frame.
+The source and the destination connection ID and the QUIC version are sufficient

I don't know what people view as source and destination when not talking about packets.  That's not something we have crisp terms for, but using source and destination here makes that problem worse.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2315#discussion_r245893468