IETF Logo Mail Archive

Re: [quicwg/base-drafts] Python linting script (#1032)

Mike Bishop <notifications@github.com> Wed, 03 January 2018 23:29 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id BA21C126CF6 for <quic-issues@ietfa.amsl.com>; Wed, 3 Jan 2018 15:29:52 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.606
X-Spam-Level:
X-Spam-Status: No, score=-0.606 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, URIBL_BLOCKED=0.001] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x30FPNwpUTou for <quic-issues@ietfa.amsl.com>; Wed, 3 Jan 2018 15:29:51 -0800 (PST)
Received: from o5.sgmail.github.com (o5.sgmail.github.com [192.254.113.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 512181241F8 for <quic-issues@ietf.org>; Wed, 3 Jan 2018 15:29:51 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=nZazPy3EJFXMhvaMZUlhUjjYpf8=; b=sFBM4kxpAHrj93QL lJdOS+/16T6q2s2v0Ppai1bFhAgi9nSJOSxu8u/5ZbHrdJXmzsyqCwXGddY1WmeJ Nnx1eIz1kxqHKVzjHN6fSLZjFp231KFDHQ9hhWKCycmAQxMmv/QrW6eN/n2/qnOr id1uX8RKMyiBfztbApovvZZwdYU=
Received: by filter0487p1mdw1.sendgrid.net with SMTP id filter0487p1mdw1-4833-5A4D676D-A 2018-01-03 23:29:49.941544293 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0012p1iad2.sendgrid.net (SG) with ESMTP id sk9w5p0FQ8i8WwlCgslPgw for <quic-issues@ietf.org>; Wed, 03 Jan 2018 23:29:49.915 +0000 (UTC)
Date: Wed, 03 Jan 2018 23:29:50 +0000
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abad0f041b21330eab8f6ddd417848c32081463bf792cf000000011665296d92a169ce10f35235@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1032/review/86521692@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1032@github.com>
References: <quicwg/base-drafts/pull/1032@github.com>
Subject: Re: [quicwg/base-drafts] Python linting script (#1032)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5a4d676dc4848_340f3f8c00f92f38223060"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3Zh/pwLBOpefVXEfVZFnglUgK60e89An2dV5 kTCFyWQPHNkXnbeJx7UOj01xUHACovekDsS2qXsqd63L2YGEbIR67VUlqvdig4fGPS9dXed8Nm9WGx IePMpf5MV+Z2tXdXgnyV+vFcRRh3efRXRmsS8Dp4pIwcTFkmicxffn9feShf3WsTFooa3dZpaKU1qw s=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/T1T8ZR6E1gb-95w-clCDV5O7vyw>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Jan 2018 23:29:53 -0000

MikeBishop commented on this pull request.



> +            ## Skip everything before abstract
+            if beforeAbstract:
+                matchObj = re.match('^--- abstract',line)
+                if matchObj:
+                    beforeAbstract = False
+                continue
+
+            ## Skip tables
+            matchObj = re.match('^\s*\|',line)
+            if matchObj:
+                continue
+
+            ## Toggle figure state
+            matchObj = re.match('^[~`]{3,}',line)
+            if matchObj:
+                insideFigure = False if insideFigure else True

Somewhat more opaque, but sure.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1032#discussion_r159553173

v2.46.0 | Report a Bug | By Email | System Status