Re: [quicwg/base-drafts] Be more specific when naming bits (#3089)

Robin Marx <> Sun, 13 October 2019 19:20 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id BDA06120024 for <>; Sun, 13 Oct 2019 12:20:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id 0RkWO51UEIwb for <>; Sun, 13 Oct 2019 12:20:58 -0700 (PDT)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id 13CA1120013 for <>; Sun, 13 Oct 2019 12:20:58 -0700 (PDT)
Received: from ( []) by (Postfix) with ESMTP id 9529C261646 for <>; Sun, 13 Oct 2019 12:20:57 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1570994457; bh=tpgC/Y/J9tzX8OzTX5/SvkMilFqWEgPwkGY1ZQl3aBo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=kzTroVXeDjA4m9wwbPt989E47F9sCHkoUHx8YbbscKOmb6UHZZjKZuVpB98ViSMSk iIaGC0za7LHIfsXdUAqhaVttR0ZwL7lvipE88/dpj91D09P1DGaNjpBcHXHc6t03sX Jsx+8i870Co6FGKDKkxlNio+X2R9fs15gGKwveWc=
Date: Sun, 13 Oct 2019 12:20:57 -0700
From: Robin Marx <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/3089/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Be more specific when naming bits (#3089)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5da3791950827_41163fa7b76cd95c4139e"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: rmarx
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Sun, 13 Oct 2019 19:21:00 -0000

rmarx commented on this pull request.

> @@ -682,10 +682,10 @@ acknowledged as this instruction does not insert an entry.
 An encoder adds an entry to the dynamic table where the header field name
 matches the header field name of an entry stored in the static or the dynamic
 table using an instruction that starts with the '1' one-bit pattern.  The second
-(`S`) bit indicates whether the reference is to the static or dynamic table. The
+('T') bit indicates whether the reference is to the static or dynamic table. The

My main gripe was that we were using S with two different meanings (Sign bit and "Static Table bit"). On slack, @afrind was ok with T, so I went with that. I see it as a table "index" personally, which makes sense to me. 

But really, I don't care which letter or noun is used, as long as the same letter/noun isn't used for different things. 

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: