Re: [quicwg/base-drafts] GOAWAY means no more (#3338)

Mike Bishop <notifications@github.com> Tue, 14 January 2020 15:18 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id F0203120121 for <quic-issues@ietfa.amsl.com>; Tue, 14 Jan 2020 07:18:05 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RVHmUAiZyfPl for <quic-issues@ietfa.amsl.com>; Tue, 14 Jan 2020 07:17:59 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id C0058120125 for <quic-issues@ietf.org>; Tue, 14 Jan 2020 07:17:58 -0800 (PST)
Received: from github-lowworker-fb56993.ac4-iad.github.net (github-lowworker-fb56993.ac4-iad.github.net [10.52.19.31]) by smtp.github.com (Postfix) with ESMTP id DFD62C6034F for <quic-issues@ietf.org>; Tue, 14 Jan 2020 07:17:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579015077; bh=/8NysNzXB2lHZxWTd6o/+dBv5ySHKY6oksgb3WufL/E=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ejAX6wr2XpOUDUyVbZEmcxTjhHKe1d8SoUb6er8wvlC41lKtdH3tpE+/HCsvB+96E 0DHb3fRs0LXjeEFLpon05p34SUvCIe6j21op//HySZWJVclSV2YVDTk4n5sFUNS7uP QfBoohdo8S7QwUqyydq0XpwWifTqEGnt1ufyKsxc=
Date: Tue, 14 Jan 2020 07:17:57 -0800
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6PR252W2DEK5DXHJN4FMHCLEVBNHHCBPAYFQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3338/review/342609841@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3338@github.com>
References: <quicwg/base-drafts/pull/3338@github.com>
Subject: Re: [quicwg/base-drafts] GOAWAY means no more (#3338)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e1ddba5d06b4_114d3fd77b2cd96c1503e7"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/T4QJtvCNJW-huOK4eZVrc3bsRm8>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jan 2020 15:18:06 -0000

MikeBishop commented on this pull request.



> @@ -696,18 +696,19 @@ requests or pushes were accepted prior to the connection shutdown.  Endpoints
 SHOULD abruptly terminate any requests or pushes that have identifiers greater
 than or equal to the smallest identifier sent in a GOAWAY frame.
 
-Endpoints MUST NOT initiate new requests or pushes on the connection with an
-identifier greater than or equal to the smallest identifier received in a GOAWAY
-frame.  Clients MAY establish a new connection to send additional requests.
+Endpoints MUST NOT initiate new requests or promise new pushes on the connection
+after receipt of a GOAWAY from the peer.  Clients MAY establish a new connection

Thanks -- I found a few other places where just "GOAWAY" was used, and fixed them as well.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3338#discussion_r366397374