Re: [quicwg/base-drafts] Why do we have final size? (#3739)

[Kazuho Oku <[e-mail]>]

@kazuho commented on this pull request.



> @@ -908,10 +908,11 @@ final size is the number of bytes sent.  More generally, this is one higher
 than the offset of the byte with the largest offset sent on the stream, or zero
 if no bytes were sent.
 
-For a stream that is reset, the final size is carried explicitly in a
-RESET_STREAM frame.  Otherwise, the final size is the offset plus the length of
-a STREAM frame marked with a FIN flag, or 0 in the case of incoming
-unidirectional streams.
+At the end of a stream, the sender communicates the final size to the recipient,
+ensuring flow control state is synchronized.  For a stream that is reset, the
+final size is carried explicitly in a RESET_STREAM frame.  Otherwise, the final
+size is the offset plus the length of a STREAM frame marked with a FIN flag, or
+0 in the case of incoming unidirectional streams.

To me it seems that the text starting from "or, ..." is confusing. That is because a "sender" does not communicate the final size of incoming undirectional stream, contrary to what the first sentence of this paragraph suggests.

I think it might make sense to either simply drop "or... ", or modify the first sentence to state that such communication is made for streams that has the send side.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3739#pullrequestreview-425699692