Re: [quicwg/base-drafts] grease transport parameters (#2873)

Martin Thomson <notifications@github.com> Tue, 09 July 2019 04:07 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id CBD201200FD for <quic-issues@ietfa.amsl.com>; Mon, 8 Jul 2019 21:07:59 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.454
X-Spam-Level:
X-Spam-Status: No, score=-6.454 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iZvBcbIwQwEK for <quic-issues@ietfa.amsl.com>; Mon, 8 Jul 2019 21:07:58 -0700 (PDT)
Received: from out-6.smtp.github.com (out-6.smtp.github.com [192.30.252.197]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DDFE31200F3 for <quic-issues@ietf.org>; Mon, 8 Jul 2019 21:07:57 -0700 (PDT)
Date: Mon, 08 Jul 2019 21:07:56 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1562645276; bh=elUFnj72555S1A0SNrqGLm0oMCwO68ZVI3FexDbiZMo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=SEzcSIB4DP4+/ojR15KX2b3ZOq7mb377tDkN56wZ1RyFa6NSZ/gDLSUYtEaRdVTeV gwhLd3C+Sz2koV/Ouq9ec7DVnO7eKaScvFgTQDywL5mkMU6n1H2WGAccASHzSFXBCn V03rToKj7CDQygc1XAiU53/F4rzQWVoVhQJbZfTU=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZEYBTGI4EMT2BUFOV3GFCZZEVBNHHBXMLRZE@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2873/review/259260155@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2873@github.com>
References: <quicwg/base-drafts/pull/2873@github.com>
Subject: Re: [quicwg/base-drafts] grease transport parameters (#2873)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5d24131cc67d9_73253f980b4cd9607942ce"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/TC-alA-CW-iPuyANaO9YEYPyDPk>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jul 2019 04:08:00 -0000

martinthomson requested changes on this pull request.

This looks good to me, with one omission.

(BTW, thanks for fixing the xref, I would not have and even Julian's tools wouldn't have found that.)

Can you update the IANA considerations section as well?



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2873#pullrequestreview-259260155