Date: Wed, 13 Mar 2019 15:48:40 +0000 (UTC)
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts
 <reply+0166e4abca3d960708d88d7c93600651e184a47ec4b293dd92cf0000000118a0e85892a169ce18e318a8@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2499/review/214041947@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2499@github.com>
References: <quicwg/base-drafts/pull/2499@github.com>
Subject: Re: [quicwg/base-drafts] Close the connection if MAX_STREAMS is too
 large (#2499)
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary="--==_mimepart_5c8926586a080_30c3fa09c2d45c049591e";
 charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/TH3U1Xv3z0imoJ4RpPJR1WSMTj8>

----==_mimepart_5c8926586a080_30c3fa09c2d45c049591e
Content-Type: text/plain;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

ianswett commented on this pull request.



> @@ -851,6 +851,12 @@ limits are set in the transport parameters (see
 using MAX_STREAMS frames ({{frame-max-streams}}). Separate limits apply to
 unidirectional and bidirectional streams.
 
+If a max_streams transport parameter or MAX_STREAMS frame is received with a
+value greater than 2^60, this allows a maximum stream ID that cannot be
+expressed as a variable-length integer (see {{integer-encoding}}).

SG, done.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2499#discussion_r265197570
----==_mimepart_5c8926586a080_30c3fa09c2d45c049591e
Content-Type: text/html;
 charset=UTF-8
Content-Transfer-Encoding: 7bit

<p><b>@ianswett</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/quicwg/base-drafts/pull/2499#discussion_r265197570">draft-ietf-quic-transport.md</a>:</p>
<pre style='color:#555'>&gt; @@ -851,6 +851,12 @@ limits are set in the transport parameters (see
 using MAX_STREAMS frames ({{frame-max-streams}}). Separate limits apply to
 unidirectional and bidirectional streams.
 
+If a max_streams transport parameter or MAX_STREAMS frame is received with a
+value greater than 2^60, this allows a maximum stream ID that cannot be
+expressed as a variable-length integer (see {{integer-encoding}}).
</pre>
<p>SG, done.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/quicwg/base-drafts/pull/2499#discussion_r265197570">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AWbkq81M3JMl5KfIi683mCNAIZu-tH_9ks5vWR3YgaJpZM4bfp5V">mute the thread</a>.<img src="https://github.com/notifications/beacon/AWbkq1PyraTEiFjwapSbIMLy7yxPXMr5ks5vWR3YgaJpZM4bfp5V.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/quicwg/base-drafts","title":"quicwg/base-drafts","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/quicwg/base-drafts"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ianswett commented on #2499"}],"action":{"name":"View Pull Request","url":"https://github.com/quicwg/base-drafts/pull/2499#discussion_r265197570"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/quicwg/base-drafts/pull/2499#discussion_r265197570",
"url": "https://github.com/quicwg/base-drafts/pull/2499#discussion_r265197570",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
----==_mimepart_5c8926586a080_30c3fa09c2d45c049591e--