Re: [quicwg/base-drafts] Migration with zero-length CID is inadvisable (#3563)

David Schinazi <notifications@github.com> Tue, 31 March 2020 23:52 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 89EC33A0D9C for <quic-issues@ietfa.amsl.com>; Tue, 31 Mar 2020 16:52:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 0.082
X-Spam-Level:
X-Spam-Status: No, score=0.082 tagged_above=-999 required=5 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_24=1.282, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3GYrO7Z_x4rL for <quic-issues@ietfa.amsl.com>; Tue, 31 Mar 2020 16:52:55 -0700 (PDT)
Received: from out-18.smtp.github.com (out-18.smtp.github.com [192.30.252.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BEBF73A0D9B for <quic-issues@ietf.org>; Tue, 31 Mar 2020 16:52:54 -0700 (PDT)
Received: from github-lowworker-292e294.va3-iad.github.net (github-lowworker-292e294.va3-iad.github.net [10.48.102.70]) by smtp.github.com (Postfix) with ESMTP id 0E28D6E1330 for <quic-issues@ietf.org>; Tue, 31 Mar 2020 16:52:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1585698774; bh=gXTAP+CoDLQRbg57e0xFiZasd09ox5XWw0E/kIr8S58=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=k2J4nJfHuxJF4QKNYwAtyraTNeOSWBkR2hC2QsRnhgOys9JAx060OVy64jLPD04Y/ 12AAOlDrd4CjLLB0hSuaGSoZoylB0XMOxPNKfqMrYSbBfqwuo/UITK1tbgBC+FbgNL XFoZjKjKCiKrLj188ewM/HwarJ5LCk0dGmTDfUyY=
Date: Tue, 31 Mar 2020 16:52:53 -0700
From: David Schinazi <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2IEH4O65RJNC7H4KV4R64NLEVBNHHCGQM7OQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3563/review/385180000@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3563@github.com>
References: <quicwg/base-drafts/pull/3563@github.com>
Subject: Re: [quicwg/base-drafts] Migration with zero-length CID is inadvisable (#3563)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e83d7d5f2434_64103fb58f2cd95c692be"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: DavidSchinazi
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/TOCodvfya40J9plI0o0mpCDyzck>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 31 Mar 2020 23:52:57 -0000

@DavidSchinazi commented on this pull request.

I'm not sure this guidance is correct. If the server has reason to believe migration won't work (due to source-IP routing or otherwise) it should send the disable_migration TP. It's perfectly reasonable to migrate when zero-length CIDs are in use if the server only has one connection on this port. Therefore I think we should stay away from the implicit signal "CID is zero-length" and instead use the explicit signal disable_migration.

> @@ -2246,6 +2246,13 @@ that packet numbers cannot be used to correlate activity.  This does not prevent
 other properties of packets, such as timing and size, from being used to
 correlate activity.
 
+An endpoint SHOULD NOT initiate migration when a peer that requests the use of

I'm failing to parse this first sentence.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3563#pullrequestreview-385180000