IETF Logo Mail Archive

Re: [quicwg/base-drafts] split fast retransmit modes (#1226)

Subodh Iyengar <notifications@github.com> Sun, 18 March 2018 14:01 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 30D5912711A for <quic-issues@ietfa.amsl.com>; Sun, 18 Mar 2018 07:01:21 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -0.392
X-Spam-Level:
X-Spam-Status: No, score=-0.392 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=no autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ovZDqI0Ph5YW for <quic-issues@ietfa.amsl.com>; Sun, 18 Mar 2018 07:01:20 -0700 (PDT)
Received: from o3.sgmail.github.com (o3.sgmail.github.com [192.254.112.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 1AE07126C0F for <quic-issues@ietf.org>; Sun, 18 Mar 2018 07:01:20 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=00do7LqTnvie5MpvEHsX+ZvLCkY=; b=szexqPwUniZfeJ82 J7RLSYU6Otf9DOoCKLttWwIRkAHFm+gfYawsGZzxyg3la1EEM2FjhkAnO1RZNKjW RSBYid9T75SoAfpPZmdJNNGwjRHTF2ZNHIroGNY4OEvWwNzpInQ7HNS01UaREtdc OU4GqxL67NMayo4uceFU+KN/VsE=
Received: by filter0016p1las1.sendgrid.net with SMTP id filter0016p1las1-11495-5AAE712F-16 2018-03-18 14:01:19.593698388 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16]) by ismtpd0023p1iad2.sendgrid.net (SG) with ESMTP id lRfzrm44QxyuXxjhh-eppA for <quic-issues@ietf.org>; Sun, 18 Mar 2018 14:01:19.363 +0000 (UTC)
Date: Sun, 18 Mar 2018 14:01:19 +0000
From: Subodh Iyengar <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abc7b308e64365594bded5747736fac5731cc0bb0192cf0000000116c6332f92a169ce1240b5ea@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1226/review/104798302@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1226@github.com>
References: <quicwg/base-drafts/pull/1226@github.com>
Subject: Re: [quicwg/base-drafts] split fast retransmit modes (#1226)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5aae712f5fefb_ade2acb6cdb0ecc784823"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: siyengar
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak1BclZ/dQJFuyM2CrqqcvkMNWlruZDDnV5Igh TH4ZwYgl4wzcFdPuWwsumpfymPRkRzGvYs4QUz9Pk8MFVLGJxeOL/s7MmO6wZwJOS678wv8V6p0cz3 3hDEfqLntRvMoES1lxnVEx/eKvjTcb5u/uRyZStCX8vJYcwNhX7newv0jcf8OFgg1PAp1qkFYQRI4F Q=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/TSG8i5qemIoxoispCRV3Gw8q6IA>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Mar 2018 14:01:21 -0000

siyengar commented on this pull request.



> @@ -846,6 +843,29 @@ DetectLostPackets(largest_acked):
     else if (loss_time == 0 && delay_until_lost != infinite):
       loss_time = now() + delay_until_lost - time_since_sent

sorry i meant first_unacked.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1226#discussion_r175290237

v2.46.0 | Report a Bug | By Email | System Status