Re: [quicwg/base-drafts] renamed max_packet_size to max_udp_size (#3473)

David Schinazi <notifications@github.com> Fri, 21 February 2020 00:16 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 8E9C61202DD for <quic-issues@ietfa.amsl.com>; Thu, 20 Feb 2020 16:16:44 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id R3qRDn1J7BhL for <quic-issues@ietfa.amsl.com>; Thu, 20 Feb 2020 16:16:43 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 38257120152 for <quic-issues@ietf.org>; Thu, 20 Feb 2020 16:16:43 -0800 (PST)
Received: from github-lowworker-f62aa54.va3-iad.github.net (github-lowworker-f62aa54.va3-iad.github.net [10.48.17.68]) by smtp.github.com (Postfix) with ESMTP id F3F7B960596 for <quic-issues@ietf.org>; Thu, 20 Feb 2020 16:16:41 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1582244201; bh=SC7vv4Xnl9PweCwjKJNWj94EL9eWN3hPw6vs+c1z9r0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Z8p1sIJkoR1bF7RsQ/HzJMVLRYNBLrDW6LPZN3ksgd9MPQwIadqRe/kI/atlJzcF1 jqZm6cWkqEdB8rbKIHuolOQFMTGt4yw3IUQaYjGUD++tSNMHVD4/0kY8s9xtnqi16a KZ9hvwFK8sNu+JpmHhmdw6V3GodwdAz+hCfJVI78=
Date: Thu, 20 Feb 2020 16:16:41 -0800
From: David Schinazi <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK2NTCNKEA5WH7O2O4N4LRJ6TEVBNHHCDZCX6I@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3473/review/362326403@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3473@github.com>
References: <quicwg/base-drafts/pull/3473@github.com>
Subject: Re: [quicwg/base-drafts] renamed max_packet_size to max_udp_size (#3473)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e4f2169e4fdc_28c83fafd1ccd95c898f3"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: DavidSchinazi
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/TaXjN25k1fdsCSdBddYUJUwptKE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Feb 2020 00:16:45 -0000

DavidSchinazi commented on this pull request.



>  
-: The maximum packet size parameter is an integer value that limits the size of
-  packets that the endpoint is willing to receive.  This indicates that packets
-  larger than this limit will be dropped.  The default for this parameter is the
-  maximum permitted UDP payload of 65527.  Values below 1200 are invalid.  This
-  limit only applies to protected packets ({{packet-protected}}).
+: The maximum udp size parameter is an integer value that limits the size of
+  UDP payloads that the endpoint is willing to receive.  This indicates that
+  packets larger than this limit are likely not to be processed by the receiver.

Are we really concerned about nodes performing this check? My understanding is that we added this transport parameter in the first place to allow folks to read UDP into a fixed-size stack buffer, and this allows an endpoint to communicate the size of that buffer to its peer. If I'm able to decrypt this packet it means I'm able to read and process it, so I shouldn't be sending a lower transport parameter. I think the sentence I propose above makes it clear that this is advisory and should not be enforced.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3473#discussion_r382332227