Re: [quicwg/base-drafts] Don't arm the handshake timer if there's no data (#2590)

martinduke <notifications@github.com> Mon, 08 April 2019 07:41 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 4D73C1201B6 for <quic-issues@ietfa.amsl.com>; Mon, 8 Apr 2019 00:41:45 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.001
X-Spam-Level:
X-Spam-Status: No, score=-8.001 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id O4hE8YRZmkEh for <quic-issues@ietfa.amsl.com>; Mon, 8 Apr 2019 00:41:43 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 12482120193 for <quic-issues@ietf.org>; Mon, 8 Apr 2019 00:41:43 -0700 (PDT)
Date: Mon, 08 Apr 2019 00:41:41 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1554709301; bh=mqLnbvrvRQbU8jmYiIxONwgu/9y/DSFf+QpRrC0r8Ao=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wmX3hqzpxGPoftuNjtABColPbqPRWLFujd7e1ALYjunCoPSJS98MZFp+MNlh83aYt r+rq8nHVXm9jYEKviOD20ZgA5cWt1LqxxXMtpJ61uqWwIJx4MC/EDi5zQn4WRugVMO Dwms5QeeF+kLSxC53JSy7xlpKs8rfSjZSgrneFZI=
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab4eabc4d8b2996495d2b3210a1e1d1f3742beeb7a92cf0000000118c2bd3592a169ce199da23e@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2590/c480720320@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2590@github.com>
References: <quicwg/base-drafts/pull/2590@github.com>
Subject: Re: [quicwg/base-drafts] Don't arm the handshake timer if there's no data (#2590)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5caafb35c8cbb_db03f89d92d45b8499675"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/TcQBKIFnEU3gJpOqO_kh1vmZ2z4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 08 Apr 2019 07:41:45 -0000

If the server first flight does not include finished and the client
handshake ack is lost, the client has no unacked data but the server is
flow control limited.

On Sun, Apr 7, 2019, 20:43 Marten Seemann <notifications@github.com> wrote:

> *@marten-seemann* commented on this pull request.
> ------------------------------
>
> In draft-ietf-quic-recovery.md
> <https://github.com/quicwg/base-drafts/pull/2590#discussion_r272877569>:
>
> > @@ -458,17 +462,16 @@ sent, then no alarm should be armed until data has been received from the
>
>  client.
>
>
>
>  Because the server could be blocked until more packets are received, the client
>
> -MUST start the crypto retransmission timer even if there is no unacknowledged
>
> -CRYPTO data.  If the timer expires and the client has no CRYPTO data to
>
> -retransmit and does not have Handshake keys, it SHOULD send an Initial packet in
>
> -a UDP datagram of at least 1200 bytes.  If the client has Handshake keys, it
>
> -SHOULD send a Handshake packet.
>
> -
>
> -On each consecutive expiration of the crypto timer without receiving an
>
> -acknowledgement for a new packet, the sender SHOULD double the crypto
>
> -retransmission timeout and set a timer for this period.
>
> +MUST ensure the crypto retransmission timer is set if there is unacknowledged
>
> +crypto data and MUST ensure the timer is set until it has 1-RTT keys.
>
> +If the timer expires and the client has no CRYPTO data to retransmit and does
>
> +not have Handshake keys, it MUST send an Initial packet in a UDP datagram of
>
> +at least 1200 bytes.  If the client has Handshake keys, it MUST send a
>
>
> Why would the client send a Handshake packet if there’s no CRYPTO data to
> retransmit? If there’s no Handshake CRYPTO data to retransmit, this means
> that the server already received the client‘s TLS messages sent with
> Handshake keys, and won’t be blocked by the 3x Limit any more, doesn’t it?
>
> —
> You are receiving this because your review was requested.
> Reply to this email directly, view it on GitHub
> <https://github.com/quicwg/base-drafts/pull/2590#pullrequestreview-223632964>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AXRMEZLB_4dnuds0LhuvnVg5c60SndfPks5verrhgaJpZM4ce8zS>
> .
>


-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2590#issuecomment-480720320