Re: [quicwg/base-drafts] Allow not creating QPACK codec streams (#2529)
afrind <notifications@github.com> Wed, 20 March 2019 20:13 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 349D7124BA8 for <quic-issues@ietfa.amsl.com>; Wed, 20 Mar 2019 13:13:36 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.002
X-Spam-Level:
X-Spam-Status: No, score=-8.002 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VEQGm-acabwx for <quic-issues@ietfa.amsl.com>; Wed, 20 Mar 2019 13:13:34 -0700 (PDT)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E20831228B7 for <quic-issues@ietf.org>; Wed, 20 Mar 2019 13:13:33 -0700 (PDT)
Date: Wed, 20 Mar 2019 13:13:32 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1553112812; bh=aHNyz002JCrgv89oRaeStx2BYqFmChXcYx9VFa9Q46c=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=BaJEdDVi27+El1O98aXdDP0eaZaC6zQZj3ZAr8tu/KeId/7Do2A/gdY/uhkAvyM84 DL/fKnwaJfdtxuohUZi/PLDowIlMC7ZFrRqV0pgmzsD72f0zVFb9m2Cdg/UMmEK8yt 2ta6/a8PFkPPCRqhd/4fMJO0jHoSTP/TSWnKjnQ4=
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab763d53bb739d8dcd6ffbabb256f90eee4bdc40cd92cf0000000118aa60ec92a169ce1931c3e6@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2529/review/216952679@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2529@github.com>
References: <quicwg/base-drafts/pull/2529@github.com>
Subject: Re: [quicwg/base-drafts] Allow not creating QPACK codec streams (#2529)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c929eece62ac_4663f9b484d45b81243f5"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Tq7JuEly-C-GyFcdNt4uM9FpodQ>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 20 Mar 2019 20:13:36 -0000
afrind commented on this pull request. > HTTP_WRONG_STREAM_COUNT. These streams MUST NOT be closed. Closure of either unidirectional stream type MUST be treated as a connection error of type HTTP_CLOSED_CRITICAL_STREAM. +An endpoint MAY avoid creating its own encoder stream if the maximum size of @LPardue : The explicit signal is the arrival of a Set Dynamic Table Capacity instruction on the encoder stream with a non-zero capacity (or perhaps the arrival of a header block with a non-zero Required Insert Count, if there's reordering or loss). I don't see any problem with this - what's the specific concern? It's actually an improvement over HPACK, where the receiver assumes the sender will use the table by virtue of the non-zero default max capacity. Implementations that never use the dynamic table might not be kind enough to send an Update Table Size with size=0. For the language here, would it read better the other way around: "The encoder need only open the encoder stream if it wishes to use the dynamic table and is permitted to do so by the decoder" - or something to that effect? > HTTP_WRONG_STREAM_COUNT. These streams MUST NOT be closed. Closure of either unidirectional stream type MUST be treated as a connection error of type HTTP_CLOSED_CRITICAL_STREAM. +An endpoint MAY avoid creating its own encoder stream if the maximum size of +the dynamic table permitted by the peer is zero. + +An endpoint MAY avoid creating its own decoder stream if the maximum size of +its own dynamic table is zero. + +An endpoint MUST allow its peer to create both encoder and decoder streams > Both clients and servers SHOULD send a value of three or greater for the QUIC transport parameter initial_max_uni_streams. I think the current consensus regarding QPACK streams is that you cannot prevent their creation, so clients and servers MUST give 3 or more. If we allow the peer to limit to one unidirectional stream, there's potentially nothing from stopping an implementation from using that to create an encoder or decoder stream. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2529#discussion_r267522635
- [quicwg/base-drafts] Allow not creating QPACK cod… Alessandro Ghedini
- Re: [quicwg/base-drafts] Allow not creating QPACK… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Allow not creating QPACK… Lucas Pardue
- Re: [quicwg/base-drafts] Allow not creating QPACK… ianswett
- Re: [quicwg/base-drafts] Allow not creating QPACK… Lucas Pardue
- Re: [quicwg/base-drafts] Allow not creating QPACK… Kazuho Oku
- Re: [quicwg/base-drafts] Allow not creating QPACK… Alessandro Ghedini
- Re: [quicwg/base-drafts] Allow not creating QPACK… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Allow not creating QPACK… afrind
- Re: [quicwg/base-drafts] Allow not creating QPACK… Dmitri Tikhonov
- Re: [quicwg/base-drafts] Allow not creating QPACK… Lucas Pardue
- Re: [quicwg/base-drafts] Allow not creating QPACK… afrind
- Re: [quicwg/base-drafts] Allow not creating QPACK… Lucas Pardue
- Re: [quicwg/base-drafts] Allow not creating QPACK… afrind
- Re: [quicwg/base-drafts] Allow not creating QPACK… Lucas Pardue
- Re: [quicwg/base-drafts] Allow not creating QPACK… afrind
- Re: [quicwg/base-drafts] Allow not creating QPACK… Lucas Pardue
- Re: [quicwg/base-drafts] Allow not creating QPACK… Bence Béky
- Re: [quicwg/base-drafts] Allow not creating QPACK… Alessandro Ghedini
- Re: [quicwg/base-drafts] Allow not creating QPACK… Mike Bishop
- Re: [quicwg/base-drafts] Allow not creating QPACK… Bence Béky
- Re: [quicwg/base-drafts] Allow not creating QPACK… afrind
- Re: [quicwg/base-drafts] Allow not creating QPACK… Alessandro Ghedini
- Re: [quicwg/base-drafts] Allow not creating QPACK… Alessandro Ghedini
- Re: [quicwg/base-drafts] Allow not creating QPACK… Alessandro Ghedini
- Re: [quicwg/base-drafts] Allow not creating QPACK… Alessandro Ghedini
- Re: [quicwg/base-drafts] Allow not creating QPACK… afrind