Re: [quicwg/base-drafts] Update PTO pseudocode to better match text (#3461)

ianswett <notifications@github.com> Mon, 17 February 2020 01:01 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DC67012008A for <quic-issues@ietfa.amsl.com>; Sun, 16 Feb 2020 17:01:59 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gBjYhpIkGagA for <quic-issues@ietfa.amsl.com>; Sun, 16 Feb 2020 17:01:58 -0800 (PST)
Received: from out-27.smtp.github.com (out-27.smtp.github.com [192.30.252.210]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 16D05120024 for <quic-issues@ietf.org>; Sun, 16 Feb 2020 17:01:58 -0800 (PST)
Received: from github-lowworker-28f8021.ac4-iad.github.net (github-lowworker-28f8021.ac4-iad.github.net [10.52.25.98]) by smtp.github.com (Postfix) with ESMTP id 6FF8AE0059 for <quic-issues@ietf.org>; Sun, 16 Feb 2020 17:01:57 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1581901317; bh=zQJX0o1Kugw1XBq7Drqk56Vmz3pbGH3IQpDmXyPCI+U=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=C/0HM4ctUp33vJBXLg7GnPOoYALvu4qvLoGz6hqzTPKuOqBi2vG/b0dE/6rwLMOoV 1ANHrhCFe9d2OLxc/w/nDx+NcisT3pYLU0YK7SmU5q4g0DS9Eyj4mZM0rXRkxxLSq0 J9/ORHn1OLZHz3BsIRk+4AKWnDeljS32Nr1GwJgA=
Date: Sun, 16 Feb 2020 17:01:57 -0800
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK52RARAVUQVERFC5F54K4MILEVBNHHCDOLCFM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3461/review/359447111@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3461@github.com>
References: <quicwg/base-drafts/pull/3461@github.com>
Subject: Re: [quicwg/base-drafts] Update PTO pseudocode to better match text (#3461)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e49e6055f5e0_3ee53fe1aaccd96082699"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/TrokFBisDzFnnJaF_-bsEeV-fX4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Feb 2020 01:02:00 -0000

ianswett commented on this pull request.



> @@ -1179,20 +1179,20 @@ OnLossDetectionTimeout():
     SetLossDetectionTimer()
     return
 
-  if (endpoint is client without 1-RTT keys):
+  if (bytes_in_flight > 0):
+    // PTO. Send new data if available, else retransmit old data.
+    // If neither is available, send a single PING frame.
+    _, pn_space = GetEarliestTimeAndSpace(
+      time_of_last_sent_ack_eliciting_packet)
+    SendOneOrTwoAckElicitingPackets(pn_space)
+  else:

The alarm shouldn't be armed in those case, as stated above in the normative text
"If no data can be sent, then the PTO alarm MUST NOT be armed until datagrams have been received from the client."

Would you like some pseudocode added to the "Setting the Loss Detection Timer" pseudocode?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3461#discussion_r379951368