Re: [quicwg/base-drafts] use TRANSPORT_PARAMETER_ERROR when authenticating connection IDs (#3691)

Martin Thomson <notifications@github.com> Thu, 28 May 2020 13:53 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6DA3B3A0ED2 for <quic-issues@ietfa.amsl.com>; Thu, 28 May 2020 06:53:02 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rZtBEZvauviM for <quic-issues@ietfa.amsl.com>; Thu, 28 May 2020 06:53:01 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 3B1BF3A0ECF for <quic-issues@ietf.org>; Thu, 28 May 2020 06:53:01 -0700 (PDT)
Received: from github-lowworker-c53a806.ac4-iad.github.net (github-lowworker-c53a806.ac4-iad.github.net [10.52.23.45]) by smtp.github.com (Postfix) with ESMTP id D96F7C604FE for <quic-issues@ietf.org>; Thu, 28 May 2020 06:52:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1590673979; bh=ViNUp585S9MGnYPglHPbkeuZbzuEYFeqFzT86+jVgQ0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=eaMMutBtYTA0bRyw2+LjlB85lCAYVFJdwkMlFpJ6Or9KAx15wkvPzgx6YjdYzuA9k witCwmlOLhnVzo9jHROBIkq9K7Kqyy7dyOX1PgwwPKJDt0f9lkzSlR4TpOoWHZyF1d QGAgGm9H95pMxTaEWv1yP3DanjJ8hHf5mxUC+QTE=
Date: Thu, 28 May 2020 06:52:59 -0700
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6NVMPNXIQIOSOEEP543ORTXEVBNHHCKLSLMI@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3691/review/420128404@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3691@github.com>
References: <quicwg/base-drafts/pull/3691@github.com>
Subject: Re: [quicwg/base-drafts] use TRANSPORT_PARAMETER_ERROR when authenticating connection IDs (#3691)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5ecfc23bc9c7f_cc73f81638cd95c1682bd"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/TsHWe2sVakMJCWzKFgSgCF_K8hs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 28 May 2020 13:53:02 -0000

@martinthomson commented on this pull request.

If you take the suggestions here, I will mark this for inclusion in the next consensus call.  (Otherwise, we should continue discussion.)

> +An endpoint MUST treat the following as a connection error of type
+PROTOCOL_VIOLATION:

```suggestion
An endpoint MUST treat the following as a connection error of type
TRANSPORT_PARAMETER_ERROR or PROTOCOL_VIOLATION:
```

Just to enact the suggestion from below and avoid ambiguity.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3691#pullrequestreview-420128404