Re: [quicwg/base-drafts] renamed max_packet_size to max_udp_size (#3473)

Martin Thomson <notifications@github.com> Fri, 21 February 2020 04:25 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 69051120639 for <quic-issues@ietfa.amsl.com>; Thu, 20 Feb 2020 20:25:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hpkvjmgBVW5C for <quic-issues@ietfa.amsl.com>; Thu, 20 Feb 2020 20:25:14 -0800 (PST)
Received: from out-9.smtp.github.com (out-9.smtp.github.com [192.30.254.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 935B512013D for <quic-issues@ietf.org>; Thu, 20 Feb 2020 20:25:14 -0800 (PST)
Received: from github-lowworker-39b4a70.va3-iad.github.net (github-lowworker-39b4a70.va3-iad.github.net [10.48.16.66]) by smtp.github.com (Postfix) with ESMTP id 5F86A26156E for <quic-issues@ietf.org>; Thu, 20 Feb 2020 20:25:13 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1582259113; bh=t6qFpc57urXmA64XQYkxe9RnjKiWiyUhztiUx/PQPqY=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=DbHMYpfHNOYvOIgdppFQZgdSTm/UmXfP2xrHpwUEtsKJuBfR6LiZc2tjc2ailEqkK j4ee/f18lVwIHIAVeO/45A9pQH2vHOTMb8YspEa5LlaY6wGaW70P+TqlCIJLOwgRgx LU2+NbK5/6NpHmwUhUg1ssk7MsDBda3rrCAm5jbc=
Date: Thu, 20 Feb 2020 20:25:13 -0800
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK4NQ75EE4Y4QAQWSKV4LSHCTEVBNHHCDZCX6I@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3473/review/362392179@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3473@github.com>
References: <quicwg/base-drafts/pull/3473@github.com>
Subject: Re: [quicwg/base-drafts] renamed max_packet_size to max_udp_size (#3473)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e4f5ba918f41_2cb93f9c094cd9682036b6"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/TuurUSJ_oP62c4rH6D8cX1x7fps>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Feb 2020 04:25:17 -0000

martinthomson requested changes on this pull request.

See the issue for a discussion of how this limit might lead to the need for additional text regarding Retry packets.

>  
-: The maximum packet size parameter is an integer value that limits the size of
-  packets that the endpoint is willing to receive.  This indicates that packets
-  larger than this limit will be dropped.  The default for this parameter is the
-  maximum permitted UDP payload of 65527.  Values below 1200 are invalid.  This
-  limit only applies to protected packets ({{packet-protected}}).
+: The maximum udp size parameter is an integer value that limits the size of

```suggestion
: The maximum UDP size parameter is an integer value that limits the size of
```

>  
-: The maximum packet size parameter is an integer value that limits the size of
-  packets that the endpoint is willing to receive.  This indicates that packets
-  larger than this limit will be dropped.  The default for this parameter is the
-  maximum permitted UDP payload of 65527.  Values below 1200 are invalid.  This
-  limit only applies to protected packets ({{packet-protected}}).
+: The maximum udp size parameter is an integer value that limits the size of
+  UDP payloads that the endpoint is willing to receive.  This indicates that
+  packets larger than this limit are likely not to be processed by the receiver.
+  The default for this parameter is the maximum permitted UDP payload of 65527.
+  Values below 1200 are invalid.  This limit only applies to protected packets

See the issue for rationale.  However, with this change it can be removed.  It does create the issue I mentioned about Retry though.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3473#pullrequestreview-362392179