Return-Path: X-Original-To: quic-issues@ietfa.amsl.com Delivered-To: quic-issues@ietfa.amsl.com Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 05F2A12F1A5 for ; Wed, 28 Nov 2018 19:40:45 -0800 (PST) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -9.46 X-Spam-Level: X-Spam-Status: No, score=-9.46 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.46, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ltB4cQB5lXKz for ; Wed, 28 Nov 2018 19:40:43 -0800 (PST) Received: from out-2.smtp.github.com (out-2.smtp.github.com [192.30.252.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E64D7126C7E for ; Wed, 28 Nov 2018 19:40:39 -0800 (PST) Date: Wed, 28 Nov 2018 19:40:38 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1543462838; bh=6TPVtsYxDqRsxK9G9cgWqSi/LyPaTn9hFH2v6WS5tR0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=JULQL9FORJ+Gi8GZftzmONNLK4cPzmxcEkgKiGwKna4iN7ekidzLlm0lOyK+z2Skx fdJqujver4LasobYNuEshb/NI17d5Dw6jVjX4xKXqPuuhiXykIUNqdhzWiZo/HQOaT ylPDc36Pd4Fe91Z3snzGAQwcNDQMcmw29MN4994c= From: janaiyengar Reply-To: quicwg/base-drafts To: quicwg/base-drafts Cc: Subscribed Message-ID: In-Reply-To: References: Subject: Re: [quicwg/base-drafts] Refactor DetectLostPackets (#2066) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5bff5fb6eb571_4d653f8db16d45c46653f"; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: list X-GitHub-Sender: janaiyengar X-GitHub-Recipient: quic-issues X-GitHub-Reason: subscribed X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: quic-issues@ietf.org Archived-At: X-BeenThere: quic-issues@ietf.org X-Mailman-Version: 2.1.29 List-Id: Notification list for GitHub issues related to the QUIC WG List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 03:40:45 -0000 ----==_mimepart_5bff5fb6eb571_4d653f8db16d45c46653f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit janaiyengar commented on this pull request. > + lost_packet_send_time = now() + lost_pn = largest_acked.packet_number - reordering_threshold + + // Time-based recovery, or early retransmit. + if (kUsingTimeLossDetection || + largest_acked.packet_number == largest_sent_packet): + loss_delay = (1 + time_reordering_fraction) * + max(latest_rtt, smoothed_rtt) + lost_send_time -= loss_delay + + foreach unacked in sent_packets: + if unacked.packet_number > largest_acked.packet_number: + continue + + if (unacked.time_sent < lost_send_time || + unacked.packet_number < lost_pn): ```suggestion unacked.packet_number <= lost_pn): ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/2066#pullrequestreview-179618270 ----==_mimepart_5bff5fb6eb571_4d653f8db16d45c46653f Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

@janaiyengar commented on this pull request.

=0D =0D
=0D =0D

In draft-ietf-quic-recovery.md:

=0D 
> +  lost_packet_send_time =3D now()=0D
+  lost_pn =3D largest_acked.packet_number - reordering_threshold=0D
+=0D
+  // Time-based recovery, or early retransmit.=0D
+  if (kUsingTimeLossDetection ||=0D
+      largest_acked.packet_number =3D=3D largest_sent_packet):=0D
+    loss_delay =3D (1 + time_reordering_fraction) *=0D
+                     max(latest_rtt, smoothed_rtt)=0D
+    lost_send_time -=3D loss_delay=0D
+=0D
+  foreach unacked in sent_packets:=0D
+    if unacked.packet_number > largest_acked.packet_number:=0D
+      continue=0D
+=0D
+    if (unacked.time_sent < lost_send_time ||=0D
+        unacked.packet_number < lost_pn):=0D
=0D =E2=AC=87=EF=B8=8F Suggested change=0D 
-        unacked.packet_number < lost_pn):=0D=

+        unacked.packet_number <=3D lost_pn):=0D
=0D =0D =0D

&m= dash;
You are receiving this because you are subscribed to this thre= ad.
Reply to this email directly, view it on GitHub, or mute the thread.

= =0D =0D = ----==_mimepart_5bff5fb6eb571_4d653f8db16d45c46653f--