IETF Logo Mail Archive

Re: [quicwg/base-drafts] Length-prefixes and flow control (#1432)

Ryan Hamilton <notifications@github.com> Thu, 02 August 2018 13:10 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DE398130E77 for <quic-issues@ietfa.amsl.com>; Thu, 2 Aug 2018 06:10:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.01
X-Spam-Level:
X-Spam-Status: No, score=-3.01 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hVCqRXKA24MW for <quic-issues@ietfa.amsl.com>; Thu, 2 Aug 2018 06:10:55 -0700 (PDT)
Received: from o7.sgmail.github.com (o7.sgmail.github.com [167.89.101.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E4E97130E39 for <quic-issues@ietf.org>; Thu, 2 Aug 2018 06:10:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=2RyJBfhRnM8d+BQfeC1HrZRmaOY=; b=ELpHeAjIpS3gefux h3uuPFwUA3CZUsxtOROHZGh4isQdwVRnrRxLJFUEmSPnLuaZ1qKfRRKdJXp5aKFl bp80aDWic7MNSgMYtYm+X1CUx9IMaAe66VNOTOcDw5l7IpKur7UQ+VFyQ2iwsI13 y20KN61r8J6LqoktMtd8gYc8ezA=
Received: by filter1240p1las1.sendgrid.net with SMTP id filter1240p1las1-16759-5B6302DD-17 2018-08-02 13:10:53.425404935 +0000 UTC m=+657910.106521906
Received: from github-lowworker-e51511d.cp1-iad.github.net (unknown [192.30.252.34]) by ismtpd0002p1iad2.sendgrid.net (SG) with ESMTP id WSxfEqNkRce4Cwx9r2rV1w for <quic-issues@ietf.org>; Thu, 02 Aug 2018 13:10:53.447 +0000 (UTC)
Received: from github.com (localhost [127.0.0.1]) by github-lowworker-e51511d.cp1-iad.github.net (Postfix) with ESMTP id 3B4EC80D14 for <quic-issues@ietf.org>; Thu, 2 Aug 2018 06:10:53 -0700 (PDT)
Date: Thu, 02 Aug 2018 13:10:53 +0000
From: Ryan Hamilton <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab2f2a1a51de367f61e03ade3cf72e4ed34e7bdcb292cf00000001177ac4dd92a169ce13b52edd@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/1432/409920483@github.com>
In-Reply-To: <quicwg/base-drafts/issues/1432@github.com>
References: <quicwg/base-drafts/issues/1432@github.com>
Subject: Re: [quicwg/base-drafts] Length-prefixes and flow control (#1432)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b6302dd39362_7d503fa113ad45b412191"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: RyanAtGoogle
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak3t2sVh7bYoQb9Jk7xiRw62rKbnxpTQtZfUzr aKhO9nbX4DFiV5h2e5MZ3tvBla45UTQS16rdGlCM6GPyanMG53luzPhDphyxjQdHd4Kjg6RfT6EfJL 85o+TsHMIp8KrQOOX4K8ScdoTVKNG3c61yCwCQ0PziQQVU+jmeoqJZ58veaGd5PPV5cTyYy9gdwulD k=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/U0nkVnci0diPV6ObRa_hT8-U1Po>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Aug 2018 13:10:57 -0000

If you want to process an entire block at once, you must have the entire block in memory, obviously. Since no application wants to buffer an unlimited amount of data, the application will have some limit on the size of the block that it accepts. If it reads the length and the length is greater than the limit, it can abort. Otherwise, I would argue, it should read the block out of the receive buffer and into an application buffer. This avoids deadlock and also prevents unlimited buffering.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/1432#issuecomment-409920483

v2.27.8 | Report a Bug | By Email | System Status