IETF Logo Mail Archive

Re: [quicwg/base-drafts] Recovery editorial update (#3234)

martinduke <notifications@github.com> Sun, 17 November 2019 00:56 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 3EABA12080D for <quic-issues@ietfa.amsl.com>; Sat, 16 Nov 2019 16:56:22 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sREYVVzW5HDd for <quic-issues@ietfa.amsl.com>; Sat, 16 Nov 2019 16:56:21 -0800 (PST)
Received: from out-17.smtp.github.com (out-17.smtp.github.com [192.30.252.200]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DF0C5120043 for <quic-issues@ietf.org>; Sat, 16 Nov 2019 16:56:20 -0800 (PST)
Date: Sat, 16 Nov 2019 16:56:20 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1573952180; bh=0t1gNk9d/xeaeNFv3UzcVCzHYaLEG4Kn3CjkYFTv/yU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ENzfHguBq+SM/9WA8pLSBa87kitomBmRxMNWOjkDmAlN0oWrQxSovMMVjCLwkw2zJ TVmw8rqwbWztInnfeuqoKLPinVWY/5tELNikezS9AjaIAEhgcKZLIkHvcxv+CaotEn nYg+akGtXPQ3fLO0IJA6zr5YBwJ3P0XlCqoZbWZ4=
From: martinduke <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3QLPUBCYQ5OSN7AIF33XGTJEVBNHHB6NQUAQ@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3234/review/317995637@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3234@github.com>
References: <quicwg/base-drafts/pull/3234@github.com>
Subject: Re: [quicwg/base-drafts] Recovery editorial update (#3234)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5dd09ab43d50e_367a3f8b32ecd964109763a"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinduke
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/U4WwixqCEACJl2__g16ZrL9L0XE>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 17 Nov 2019 00:56:22 -0000

martinduke approved this pull request.



> @@ -359,8 +354,9 @@ rttvar = 3/4 * rttvar + 1/4 * rttvar_sample
 
 # Loss Detection {#loss-detection}
 
-QUIC senders use both ack information and timeouts to detect lost packets, and
-this section provides a description of these algorithms.
+QUIC senders use acknowledgements to detect lost packets, and a probe
+time out {{pto}} to ensure acknowledgements are received. This section

...to ensure it receives acknowledgements.

> @@ -532,7 +527,7 @@ keys are available to the client, it MUST send a Handshake packet, and
 otherwise it MUST send an Initial packet in a UDP datagram of at least 1200
 bytes.
 
-Initial packets and Handshake packets may never be acknowledged, but they are
+Initial packets and Handshake packets may never be acknowledged, so they are

s/may/might

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3234#pullrequestreview-317995637

v2.23.0 | Report a Bug | By Email