Re: [quicwg/base-drafts] Update PTO pseudocode to better match text (#3461)

Martin Thomson <notifications@github.com> Mon, 17 February 2020 02:41 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6EE3A1200BA for <quic-issues@ietfa.amsl.com>; Sun, 16 Feb 2020 18:41:52 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Level:
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a4sR6D-FaEWE for <quic-issues@ietfa.amsl.com>; Sun, 16 Feb 2020 18:41:51 -0800 (PST)
Received: from out-16.smtp.github.com (out-16.smtp.github.com [192.30.254.199]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EA339120074 for <quic-issues@ietf.org>; Sun, 16 Feb 2020 18:41:50 -0800 (PST)
Date: Sun, 16 Feb 2020 18:41:50 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1581907310; bh=MfwvZ3Mzw9wos9zWBuyHSWL4zwHTcoKHc4I5jW/rt34=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=q+rqte/xXHgQm6HUveon1b0p75u2+kwneJO3hEu7VR6ep4kxkXAKllPCsYlR48K1z L4mlafNhURbRMO396/5ijQbyV66clZL5Dlui4dKzsxsNhBlEcedCqffHdmnveWaoR0 NtKgftVpoht+aPom0si8PO/g+qM6Jp4tmkNnlm4Y=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZADEVE3OCZG7CKUFN4K4X65EVBNHHCDOLCFM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3461/review/359463182@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3461@github.com>
References: <quicwg/base-drafts/pull/3461@github.com>
Subject: Re: [quicwg/base-drafts] Update PTO pseudocode to better match text (#3461)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e49fd6e41d4f_5eab3f96e0ecd96421917f"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/U98kA2OwARKN-ha3McxkzcPPlO4>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 17 Feb 2020 02:41:52 -0000

martinthomson approved this pull request.

Oh, I see how this all fits together now. I think that it's entirely too clever.

I suspect that some commentary is going to be needed to explain that the PTO timer isn't armed when

a: the server hits address validation limits (the new text), and
b: the endpoint has nothing to send (except when the client isn't sure that the server has completed validation)

> +  if (IsServerWhichReachedAddressValidationLimit()):
+    loss_detection_timer.cancel()
+    return

The odd mix of pseudo-prose and undefined functions is starting to get noticeable.

```
    if (server is at anti-amplification limit):
```

And later:

```
    if (no ack-eliciting packets in flight &&
        peer not awaiting address validation):
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3461#pullrequestreview-359463182