Re: [quicwg/base-drafts] Update PTO pseudocode to better match text (#3461)

Martin Thomson <> Mon, 17 February 2020 02:41 UTC

Return-Path: <>
Received: from localhost (localhost []) by (Postfix) with ESMTP id 6EE3A1200BA for <>; Sun, 16 Feb 2020 18:41:52 -0800 (PST)
X-Virus-Scanned: amavisd-new at
X-Spam-Flag: NO
X-Spam-Score: -6.596
X-Spam-Status: No, score=-6.596 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: (amavisd-new); dkim=pass (1024-bit key)
Received: from ([]) by localhost ( []) (amavisd-new, port 10024) with ESMTP id a4sR6D-FaEWE for <>; Sun, 16 Feb 2020 18:41:51 -0800 (PST)
Received: from ( []) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by (Postfix) with ESMTPS id EA339120074 for <>; Sun, 16 Feb 2020 18:41:50 -0800 (PST)
Date: Sun, 16 Feb 2020 18:41:50 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;; s=pf2014; t=1581907310; bh=MfwvZ3Mzw9wos9zWBuyHSWL4zwHTcoKHc4I5jW/rt34=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=q+rqte/xXHgQm6HUveon1b0p75u2+kwneJO3hEu7VR6ep4kxkXAKllPCsYlR48K1z L4mlafNhURbRMO396/5ijQbyV66clZL5Dlui4dKzsxsNhBlEcedCqffHdmnveWaoR0 NtKgftVpoht+aPom0si8PO/g+qM6Jp4tmkNnlm4Y=
From: Martin Thomson <>
Reply-To: quicwg/base-drafts <>
To: quicwg/base-drafts <>
Cc: Subscribed <>
Message-ID: <quicwg/base-drafts/pull/3461/review/>
In-Reply-To: <quicwg/base-drafts/pull/>
References: <quicwg/base-drafts/pull/>
Subject: Re: [quicwg/base-drafts] Update PTO pseudocode to better match text (#3461)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e49fd6e41d4f_5eab3f96e0ecd96421917f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
Archived-At: <>
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <>
List-Unsubscribe: <>, <>
List-Archive: <>
List-Post: <>
List-Help: <>
List-Subscribe: <>, <>
X-List-Received-Date: Mon, 17 Feb 2020 02:41:52 -0000

martinthomson approved this pull request.

Oh, I see how this all fits together now. I think that it's entirely too clever.

I suspect that some commentary is going to be needed to explain that the PTO timer isn't armed when

a: the server hits address validation limits (the new text), and
b: the endpoint has nothing to send (except when the client isn't sure that the server has completed validation)

> +  if (IsServerWhichReachedAddressValidationLimit()):
+    loss_detection_timer.cancel()
+    return

The odd mix of pseudo-prose and undefined functions is starting to get noticeable.

    if (server is at anti-amplification limit):

And later:

    if (no ack-eliciting packets in flight &&
        peer not awaiting address validation):

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub: