IETF Logo Mail Archive

Re: [quicwg/base-drafts] Move connection ID change to only Server Cleartext (#589)

Mike Bishop <notifications@github.com> Tue, 06 June 2017 12:05 UTC

Return-Path: <bounces+848413-a050-quic-issues=ietf.org@sgmail.github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 33080129442 for <quic-issues@ietfa.amsl.com>; Tue, 6 Jun 2017 05:05:12 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -3.397
X-Spam-Level:
X-Spam-Status: No, score=-3.397 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-2.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mGQZ2Viqkl62 for <quic-issues@ietfa.amsl.com>; Tue, 6 Jun 2017 05:05:10 -0700 (PDT)
Received: from o4.sgmail.github.com (o4.sgmail.github.com [192.254.112.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4270D129435 for <quic-issues@ietf.org>; Tue, 6 Jun 2017 05:05:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=github.com; h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=uB8bRzx9OJ7a7V6sKQtQXdvS0hI=; b=pTe58N9fyr1HdlD2 8aYNFKgJVFaFz0oTHGe6fAjNoKQYZVQiXBFUedQkWFpGjrBh+i3P/SrQ3ccA9QA8 w1cumsnxU/nFJXXh0P2X8RHw0OCbtvqQyk1skg+Kv+FXx4EH8T0r+1RviVITMQby ienGdC4h1GKvGdKrvkgATXhBjbI=
Received: by filter0607p1mdw1.sendgrid.net with SMTP id filter0607p1mdw1-15701-59369A6B-3A 2017-06-06 12:04:59.691856126 +0000 UTC
Received: from github-smtp2b-ext-cp1-prd.iad.github.net (github-smtp2b-ext-cp1-prd.iad.github.net [192.30.253.17]) by ismtpd0001p1iad1.sendgrid.net (SG) with ESMTP id xMDo140XS9u9M6Jhs1qxpA for <quic-issues@ietf.org>; Tue, 06 Jun 2017 12:04:59.632 +0000 (UTC)
Date: Tue, 06 Jun 2017 05:04:59 -0700
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab8adc778ea8f19dee88f2dde426d0e25eba84504b92cf00000001154e5c6b92a169ce0df019e0@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/589/review/42288113@github.com>
In-Reply-To: <quicwg/base-drafts/pull/589@github.com>
References: <quicwg/base-drafts/pull/589@github.com>
Subject: Re: [quicwg/base-drafts] Move connection ID change to only Server Cleartext (#589)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_59369a6b836cc_23dd3f82399d9c34626d4"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
X-SG-EID: l64QuQ2uJCcEyUykJbxN122A6QRmEpucztpreh3Pak2tJ2R9A62usKhAtScU5d6LZEZaz9uw/53Joh se5/Z0XON1YGY4B1i1KzMTN7D5+rc8yjAt0BBLOJvzWWhudvK+97nsdFnX5noLG0Drl4rEInLJ5VPp Spc0qV8RhwQlex5LW+IFxnqdhOBZQQ+VIF0yWdBBPsExlKemfQEhUkeEtRT52oyUCPsXcafln84Uav A=
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/UBOekSttQKjXmxzgqcnQjGukPeU>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Jun 2017 12:05:12 -0000

MikeBishop commented on this pull request.



> @@ -595,11 +592,9 @@ It carries cryptographic handshake messages and acknowledgments.  It is used
 by a server that wishes to perform a stateless retry (see
 {{stateless-retry}}).
 
-The connection ID field in a Server Stateless Retry packet contains a server
-selected value, see {{connection-id}}.
-
-The packet number field echoes the packet number of the triggering client
-packet.  This allows a client to verify that the server received its packet.
+The packet number and connection ID fields echo the packet number of the

No, the packet number field should contain the client's packet number, and the connection ID field should contain the client's connection ID.  Otherwise, this is just... weird.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/589#discussion_r120335268

v2.46.0 | Report a Bug | By Email | System Status