IETF Logo Mail Archive

Re: [quicwg/base-drafts] Rework GOAWAY text (again) (#2457)

ianswett <notifications@github.com> Wed, 13 February 2019 13:33 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 7B7C112D826 for <quic-issues@ietfa.amsl.com>; Wed, 13 Feb 2019 05:33:16 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.597
X-Spam-Level:
X-Spam-Status: No, score=-6.597 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_28=1.404, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZZ3HM6c_IndH for <quic-issues@ietfa.amsl.com>; Wed, 13 Feb 2019 05:33:13 -0800 (PST)
Received: from out-5.smtp.github.com (out-5.smtp.github.com [192.30.252.196]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id BA703128BCC for <quic-issues@ietf.org>; Wed, 13 Feb 2019 05:33:13 -0800 (PST)
Date: Wed, 13 Feb 2019 05:33:12 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1550064792; bh=1C182iOZsWmmxjmQyR+9jUCpSamzHmXyFuGD7SIo2m0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=wONCqkzWnrH4ID+pJpGQYaG2x1eHXEhQlUEsfYx7T98Z7aihOFEh602G4Y+lFJn5I Es4YQnAU6FEn8fLvOj5gPb4ME6AzG0IdghL7cpbtQusGiPvwq4yInjeiM0higeXpd4 O4xse/24KBKLKU3op9FYhqAzYAWqCMeRTNv2u3go=
From: ianswett <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abfc69d18adb0f921279e20f7d66ab1a9edeaf018f92cf00000001187bde9892a169ce18690e90@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2457/review/203210056@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2457@github.com>
References: <quicwg/base-drafts/pull/2457@github.com>
Subject: Re: [quicwg/base-drafts] Rework GOAWAY text (again) (#2457)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c641c988418d_6c2e3f95b68d45c42855ab"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: ianswett
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/UDSkoqhyRA_zDc50H6XdvGhTTns>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Feb 2019 13:33:17 -0000

ianswett commented on this pull request.



> @@ -1270,10 +1270,10 @@ client.  It is RECOMMENDED that the server explicitly reject such requests (see
 streams.  The client MAY also cancel requests which will not be processed.
 
 Requests on Stream IDs less than the Stream ID in the GOAWAY frame might have
-been processed; their status cannot be known until they are completed
-successfully, reset individually, or the connection terminates.  Servers MAY
-reject individual requests on streams below the indicated ID if these requests
-were not processed.
+been processed; their status cannot be known until a response is received, the
+stream is reset individually, or the connection terminates.  Servers MAY reject

Does reject == reset here?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2457#pullrequestreview-203210056

v2.23.0 | Report a Bug | By Email