Re: [quicwg/base-drafts] Rework GOAWAY text (again) (#2457)

Lucas Pardue <notifications@github.com> Tue, 12 February 2019 23:02 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D0777130DDA for <quic-issues@ietfa.amsl.com>; Tue, 12 Feb 2019 15:02:13 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.383
X-Spam-Level:
X-Spam-Status: No, score=-6.383 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mBfSAgtBHgGo for <quic-issues@ietfa.amsl.com>; Tue, 12 Feb 2019 15:02:12 -0800 (PST)
Received: from out-10.smtp.github.com (out-10.smtp.github.com [192.30.254.193]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E056E130DD8 for <quic-issues@ietf.org>; Tue, 12 Feb 2019 15:02:11 -0800 (PST)
Date: Tue, 12 Feb 2019 15:02:10 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1550012531; bh=699y5pRGXziHMIRj37UBkb6Ys6rhaoUta0hQ6CAnrkM=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=Nhk2rVAjf06R18q/VBrn+FMhgR7Z/bksWYAODHzNJzcZhQyJ61rgSb7xyhxiAYkJB kNnl7A9xRxm1/9rbHC22Fjj9hNhi4K/PvCUKmBrJhD6Vu0pAn4/igC0Gr1bgptz94S gfui9XsjCaCzdKLFosE2bqMjTx/v4RjfzNaIrkpc=
From: Lucas Pardue <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abf8ddeabb4a129fdbfb1cd7195a04d8d7d3600c2492cf00000001187b127292a169ce18690e90@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2457/review/202953969@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2457@github.com>
References: <quicwg/base-drafts/pull/2457@github.com>
Subject: Re: [quicwg/base-drafts] Rework GOAWAY text (again) (#2457)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c635072d436c_10c53fa954cd45b448396"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: LPardue
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/UHJZiartSVIJ43nAqumPNtijF1M>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Feb 2019 23:02:14 -0000

LPardue commented on this pull request.

To split hairs. What does "To complete successfully" mean exactly? Apologies if this is defined elsewhere but I can't seem to find It.

I presume the intention is that success means a well-defined response is fully received I.e. even a response with an error code of 4xx or 5xx is classed as successful.



-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2457#pullrequestreview-202953969