IETF Logo Mail Archive

Re: [quicwg/base-drafts] Fixing recovery pseudocode (#3909)

Junho Choi <notifications@github.com> Wed, 15 July 2020 01:16 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 240993A0B90 for <quic-issues@ietfa.amsl.com>; Tue, 14 Jul 2020 18:16:32 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kkyzEKyb9CQN for <quic-issues@ietfa.amsl.com>; Tue, 14 Jul 2020 18:16:31 -0700 (PDT)
Received: from out-19.smtp.github.com (out-19.smtp.github.com [192.30.252.202]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E44683A0B8F for <quic-issues@ietf.org>; Tue, 14 Jul 2020 18:16:30 -0700 (PDT)
Received: from github-lowworker-2e54e43.va3-iad.github.net (github-lowworker-2e54e43.va3-iad.github.net [10.48.17.27]) by smtp.github.com (Postfix) with ESMTP id 3E5A85206B7 for <quic-issues@ietf.org>; Tue, 14 Jul 2020 18:16:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1594775790; bh=kMM8UuWPYtq8kuKORm+/ECiRhR3Dg+qPsvbqrKEMHu4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=pIqi1tk/gleMXpbP0IedkgKpkiS3s0R75G9zNhRsKtossUn25iMZiR8j6ZluLRLq4 3m4yH0Jgj6me7M4Oe0cY2UbcX8wWtyLdrnYElDqLJDF94/2dM6eDioVDJNx05pofbr ZLgr3UKiB4uDbyM62n2RN07OcgthiTv0S+x5LkUo=
Date: Tue, 14 Jul 2020 18:16:30 -0700
From: Junho Choi <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK25WOJG3A6B5FI4NYN5DI465EVBNHHCOKE3XU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3909/review/448565844@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3909@github.com>
References: <quicwg/base-drafts/pull/3909@github.com>
Subject: Re: [quicwg/base-drafts] Fixing recovery pseudocode (#3909)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f0e58ee2fb2f_4db13fc5b22cd960144864"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: junhochoi
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/UO4RfzAL6a2ivV9gvhd8UO3Ost0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jul 2020 01:16:32 -0000

@junhochoi commented on this pull request.



>         if (InCongestionRecovery(packet.time_sent)):
          // Do not increase congestion window in recovery period.
-         return
+         continue

I believe these 3 `return` are correct, not `continue`. L1523 says "Do not increase congestion window in recovery period."

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3909#pullrequestreview-448565844

v2.28.0 | Report a Bug | By Email | System Status