Re: [quicwg/base-drafts] use a HANDSHAKE_DONE frame to drive the handshake to confirmation (#3145)
Kazuho Oku <notifications@github.com> Sat, 26 October 2019 08:42 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 660B212004C for <quic-issues@ietfa.amsl.com>; Sat, 26 Oct 2019 01:42:39 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id is_TXjqMQyVW for <quic-issues@ietfa.amsl.com>; Sat, 26 Oct 2019 01:42:37 -0700 (PDT)
Received: from out-24.smtp.github.com (out-24.smtp.github.com [192.30.252.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 95F0D12006E for <quic-issues@ietf.org>; Sat, 26 Oct 2019 01:42:37 -0700 (PDT)
Received: from github-lowworker-39ac79b.ac4-iad.github.net (github-lowworker-39ac79b.ac4-iad.github.net [10.52.18.15]) by smtp.github.com (Postfix) with ESMTP id C743A6A1A50 for <quic-issues@ietf.org>; Sat, 26 Oct 2019 01:42:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1572079356; bh=7vH+cKN+A5Ekj0QlSpIz83b51ETWY2HJxnY5ozHkp2k=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=klfFZv4LhwbUTB9eoYFujHfFuvzd5W7lMyINe/WqyieBuhy/k8ibFB6e51TArhGBv 22M2xoGgw+9XzUvUVkpnJI3htNd0MqgwVWNbsIcJ135XfW56b/MyVNnZek4RlQoa2y 950z3RuwjXUHX8tX+VsieRj1r/3hcZhKL9ViKrDg=
Date: Sat, 26 Oct 2019 01:42:36 -0700
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZJSYMEOU3PBKGKDAF3YE4XZEVBNHHB475TUU@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3145/review/307517743@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3145@github.com>
References: <quicwg/base-drafts/pull/3145@github.com>
Subject: Re: [quicwg/base-drafts] use a HANDSHAKE_DONE frame to drive the handshake to confirmation (#3145)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db406fcb866b_309f3f8f834cd96473764"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/UONkun-SKUte-Y_128puWgwn4rg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Oct 2019 08:42:39 -0000
kazuho commented on this pull request. > @@ -760,14 +756,9 @@ and ignoring any outstanding Initial packets. ### Discarding Handshake Keys -An endpoint MUST NOT discard its handshake keys until the TLS handshake is -confirmed ({{handshake-confirmed}}). An endpoint SHOULD discard its handshake -keys as soon as it has confirmed the handshake. Most application protocols -will send data after the handshake, resulting in acknowledgements that allow -both endpoints to discard their handshake keys promptly. Endpoints that do -not have reason to send immediately after completing the handshake MAY send -ack-eliciting frames, such as PING, which will cause the handshake to be -confirmed when they are acknowledged. +An endpoint MUST discard its handshake keys when the TLS handshake is confirmed +({{handshake-confirmed}}). The server MUST send a HANDSHAKE_DONE frame within +one round-trip time of handshake completion. @ianswett > If the server is sending HANDSHAKE_DONE, isn't it no longer 0.5RTT data? Yes. This is 1 RTT, *not* 0.5 RTT. Regarding when HANDSHAKE_DONE should be sent, my view is that it HANDSHAKE_DONE is essentially an ACK for the Handshake packet. Based on that view, I do not see a reason why it should be sent at a different timing than other acks for Handshake packets (i.e. send immediately, though an endpoint might wait for a short amount of time to bundle ACK with some other data). In practice, there is no reason to delay the emission of HANDSHAKE_DONE as much as 1 RTT in HTTP/3. The server should be sending HANDSHAKE_DONE at an early moment for letting the client know that the handshake is done before the client retransmits CF, doing so has a higher probability of having CWND increased at an earlier point. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/3145#discussion_r339292488
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… ianswett
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Kazuho Oku
- [quicwg/base-drafts] use a HANDSHAKE_DONE frame t… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Jana Iyengar
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Jana Iyengar
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Martin Thomson
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Jana Iyengar
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Kazuho Oku
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Martin Thomson
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… MikkelFJ
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Mike Bishop
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… MikkelFJ
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Martin Thomson
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Martin Thomson
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… ianswett
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Ryan Hamilton
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… David Schinazi
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Martin Thomson
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Kazuho Oku
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Kazuho Oku
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… MikkelFJ
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… MikkelFJ
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… ianswett
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… David Schinazi
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… martinduke
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… martinduke
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… martinduke
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… ianswett
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… martinduke
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Kazuho Oku
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… David Schinazi
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Jana Iyengar
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… David Schinazi
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… David Schinazi
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… ianswett
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… martinduke
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Kazuho Oku
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Christian Huitema
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Jana Iyengar
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Ryan Hamilton
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Ryan Hamilton
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Martin Thomson
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Mike Bishop
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Jana Iyengar
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Martin Thomson
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Martin Thomson
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… ianswett
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Mike Bishop
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Jana Iyengar
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Marten Seemann
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Jana Iyengar
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… MikkelFJ
- Re: [quicwg/base-drafts] use a HANDSHAKE_DONE fra… Christian Huitema