Re: [quicwg/base-drafts] GOAWAY initiating a graceful shutdown can carry a huge stream ID (#3343)

afrind <notifications@github.com> Wed, 15 January 2020 01:27 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 13C2A120041 for <quic-issues@ietfa.amsl.com>; Tue, 14 Jan 2020 17:27:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -7.999
X-Spam-Level:
X-Spam-Status: No, score=-7.999 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eYaUmzk739qX for <quic-issues@ietfa.amsl.com>; Tue, 14 Jan 2020 17:26:59 -0800 (PST)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A187B12002F for <quic-issues@ietf.org>; Tue, 14 Jan 2020 17:26:59 -0800 (PST)
Date: Tue, 14 Jan 2020 17:26:58 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1579051619; bh=MrAlGB4cv/kcHaeGFWJng4kHcOJNUietgN3WyhO6k5s=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=RC1M2ZUwHnOlIy+hHHYG5//HKvDU9LqhOtiSbBiMETuOw/iEIeYvbU7c1HQCFsb5g U/iaQrTMhyLARUW/9f948l4nxWKm2gNN9rflxjusiJsBd7m1BUpbATIUa4P9n+HNkC +5edyz+U12tcMegaUx62dRtgAv5Kk8/caWBmy62g=
From: afrind <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK6V6FSZGN737RQWBVN4FOOOFEVBNHHCBRUE74@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/3343/review/342942674@github.com>
In-Reply-To: <quicwg/base-drafts/pull/3343@github.com>
References: <quicwg/base-drafts/pull/3343@github.com>
Subject: Re: [quicwg/base-drafts] GOAWAY initiating a graceful shutdown can carry a huge stream ID (#3343)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5e1e6a62ec5a2_57bd3fcba10cd9681839af"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: afrind
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/UP-GYJjs0I6Tjx6TLJWkdocIrgY>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jan 2020 01:27:01 -0000

afrind commented on this pull request.



> @@ -727,12 +727,15 @@ indicating different stream IDs, but MUST NOT increase the value they send in
 the last Stream ID, since clients might already have retried unprocessed
 requests on another connection.  A server that is attempting to gracefully shut
 down a connection SHOULD send an initial GOAWAY frame with the last Stream ID
-set to the maximum value allowed by QUIC's MAX_STREAMS and SHOULD NOT increase
-the MAX_STREAMS limit thereafter.  This signals to the client that a shutdown is
-imminent and that initiating further requests is prohibited.  After allowing
-time for any in-flight requests (at least one round-trip time), the server MAY
-send another GOAWAY frame with an updated last Stream ID.  This ensures that a
-connection can be cleanly shut down without losing requests.
+set to the maximum value allowed by the concurrency control of QUIC for the
+client-initiated, bidirectional streams (see section 4.5 of {{QUIC-TRANSPORT}})
+or any value above that, and SHOULD forbid the QUIC transport from granting

This seems to reference an API between the HTTP and QUIC transport layers?  Would it be better to just say the server SHOULD NOT grant any more concurrency credit?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/3343#pullrequestreview-342942674