Re: [quicwg/base-drafts] Path Migration makes unjustified assumptions about a new path. (#2909)

Eric Kinnear <notifications@github.com> Wed, 23 October 2019 22:04 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B01F7120086 for <quic-issues@ietfa.amsl.com>; Wed, 23 Oct 2019 15:04:19 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8
X-Spam-Level:
X-Spam-Status: No, score=-8 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MYASVyotpS8i for <quic-issues@ietfa.amsl.com>; Wed, 23 Oct 2019 15:04:17 -0700 (PDT)
Received: from out-21.smtp.github.com (out-21.smtp.github.com [192.30.252.204]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 4F73A120019 for <quic-issues@ietf.org>; Wed, 23 Oct 2019 15:04:17 -0700 (PDT)
Date: Wed, 23 Oct 2019 15:04:16 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1571868256; bh=tOuKhwpIDvqkC3iOo8q1Bjl0jAzH6rIVXBpu10bJeV4=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=P4gJ+SAi193VlPHlx+3BqRxaCYkklG5imS0yE20FqPRo/IsT/WOMJ77wlyxDSo4Kz fCinT7pE197TgJC6jIVkoYCz5I2k7LlDrKrWFqWDcEr4sJUL+cN18m4VdnDJTmn8MX 9PpRqYn/Bp6bZ1oW2+8qURujaFwTg+tpLPsUOmMc=
From: Eric Kinnear <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJKZOTYECAEVW2UPEH2F3XYHPBEVBNHHBYAAYHM@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2909/545655532@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2909@github.com>
References: <quicwg/base-drafts/issues/2909@github.com>
Subject: Re: [quicwg/base-drafts] Path Migration makes unjustified assumptions about a new path. (#2909)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5db0ce6067d3c_1ba43f7e3cecd96c12526c"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: erickinnear
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/UVKXdryKMu4v4NuJUPIp4az7ju0>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 23 Oct 2019 22:04:20 -0000

We've summarized some discussion for these above, but to go through the resolution plan for concrete changes for each one:

----

> Section 9.4 of draft-ietf-quic-transport :
> The capacity available on the new path might not be the same as the
> old path. Packets sent on the old path SHOULD NOT contribute to
> congestion control or RTT estimation for the new path.
> GF: That would be fine IF the new path were a separate CC context, which I am not yet clear whether it is, read on:

The intent here was that either (a) you only ever have a singe CC context and you reset it for each path, or (b) you have a CC context for each path, in which case each context is strongly tied to a path and you don't need to reset anything. We require that everyone does at least (a), while not preventing folks who want to do extra work for a potential performance gain from doing (b).

Addressing this in a PR:
```
Packets sent on the old path MUST NOT contribute to congestion control or 
RTT estimation for the new path.
```
They *can* contribute to the CC/RTT estimation for the old path if it's still around and you're willing to maintain that state, which is why this (mistakenly) was a SHOULD.

----
> —
> Section 9.4 of draft-ietf-quic-transport :
> On confirming a peer's ownership of its new address, an endpoint
> SHOULD immediately reset the congestion controller and round-trip
> time estimator for the new path.
> GF: Why not MUST? - because I think this is a new path, I think it can only be should if something > can confirm this is the same set of network-devices and classifiers on the path. I don't know how > you would know that, and I don't like the guess.
> —

Yes, this should be a MUST, because the CC/RTT for that path has to be reset for a new address, either by making a new one for the new path and keeping the old one around for the old path, or by resetting your single one.

This is now a MUST in the current editor's copy.

----
> draft-ietf-quic-transport :
> For instance, a change in the client's port
> number is likely indicative of a rebinding in a middlebox and not a
> complete change in path.
> GF: So. maybe this is the guess, and I don't believe it! In a world of ECMP and other methods, this > needs to be treated as a potential change of path.
> —

A very good point! This is now:
```
For instance, an endpoint might infer that a change in
only the client's port number is indicative of a NAT rebinding, meaning that the
new path is likely to have similar bandwidth and round-trip time. However, this
determination will be imperfect.  If the determination is incorrect, the
congestion controller and the RTT estimator are expected to adapt to the new
path.  Generally, implementations are advised to be cautious when using previous
values on a new path.
```

This seems to address the need for caution here.

----
> Section 9.4 of draft-ietf-quic-transport:
> While multiple paths might be used during connection migration, a
> single congestion control context and a single loss recovery context
> (as described in [QUIC-RECOVERY]) may be adequate.
> GF: Well it could if the paths WERE known to be identical, but how would an endpoint guarantee that? Section 9.2 of QUIC transport seems to suggest the CC is reset for the new path, which I would agree with, but which part of QUIC recovery says that?
> —

This is intended to say that you aren't required to maintain additional per-path state, it's adequate to reset it for each path.

In recovery, the section entitled "Handshakes and New Paths" discusses initial values to use on a new path. In general, recovery seems to be an instance of CC/LR, so if transport instructed you to toss out the old one and make a new one, you'd be using initial values, etc. as specified in recovery.

Transport does *require* that you reset CC/RTT a few paragraphs above (as noted in your previous comment):
```
On confirming a peer's ownership of its new address, an endpoint MUST
immediately reset the congestion controller and round-trip time estimator for
the new path to initial values (see Sections A.3 and B.3 in {{QUIC-RECOVERY}})
unless it has knowledge that a previous send rate or round-trip time estimate is
valid for the new path.
```

----
> draft-ietf-quic-recovery:
> For instance, an
> endpoint might delay switching to a new congestion control context
> until it is confirmed that an old path is no longer needed (such as
> the case in Section 9.3.3).
> GF: This seems underspecified and novel to me. I think it may b quite OK to continue using the old path and the old CC, for a while. Same question: is this implying the two paths share a single CC > and is there some real mechanism to detect that they are really the same set of network devices on path?

I don't think we're trying to specify a new mechanism to determine equality of paths across a network. The intent here is to recommend that an endpoint be a little bit cautious about throwing out its state before it knows it's really going to be sticking with the new path.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2909#issuecomment-545655532