IETF Logo Mail Archive

Re: [quicwg/base-drafts] Fix some of the nits in #3214 (#4016)

Lars Eggert <notifications@github.com> Thu, 20 August 2020 06:22 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 0C67A3A082B for <quic-issues@ietfa.amsl.com>; Wed, 19 Aug 2020 23:22:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.555
X-Spam-Level:
X-Spam-Status: No, score=-1.555 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_IMAGE_ONLY_20=1.546, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kfdDD_UFH-wy for <quic-issues@ietfa.amsl.com>; Wed, 19 Aug 2020 23:22:55 -0700 (PDT)
Received: from out-20.smtp.github.com (out-20.smtp.github.com [192.30.252.203]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id EB3593A081B for <quic-issues@ietf.org>; Wed, 19 Aug 2020 23:22:54 -0700 (PDT)
Received: from github-lowworker-d93c4b6.va3-iad.github.net (github-lowworker-d93c4b6.va3-iad.github.net [10.48.17.47]) by smtp.github.com (Postfix) with ESMTP id 30DC5E002F for <quic-issues@ietf.org>; Wed, 19 Aug 2020 23:22:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597904574; bh=bwIo9MweTyuXFHGKK5zBcvaZS1+GEggp8fsRCma1grc=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=fZz/mAMPgLcxwp4dHp5JQmfWd3KNlW7zpuAptZGHexfyJ6wdUzc74KPMXlldbXvkR AQI+V/P0vIPeG+oL50ka2k7FLilAUeWEnJe1WFz7bpErFSc65FZY/SQEfSuaUeG4GJ H5hJ2frmV8NjiL6UFWKWunYfk3cgkVMQWVIC+fvY=
Date: Wed, 19 Aug 2020 23:22:54 -0700
From: Lars Eggert <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+AFTOJK3NSJ5LJKHRCZSXDAN5JH335EVBNHHCRJE2U4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/4016/review/471277344@github.com>
In-Reply-To: <quicwg/base-drafts/pull/4016@github.com>
References: <quicwg/base-drafts/pull/4016@github.com>
Subject: Re: [quicwg/base-drafts] Fix some of the nits in #3214 (#4016)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5f3e16be22236_2ea91964582426"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: larseggert
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/UVdiXT8u0I8KrT242y0W6wGZibs>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Aug 2020 06:22:56 -0000

@larseggert commented on this pull request.



> -subsequent ACK frames; see {{generating-acks}} and {{frame-ack}}.  Note that
-this requires being able to read the ECN codepoints from the enclosing IP
-packet, which is not possible on all platforms.

Am fine with leaving this as is. @gorryfair?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/4016#discussion_r473641512

v2.23.0 | Report a Bug | By Email