Re: [quicwg/base-drafts] lost_pn can go negative (#2611)

Marten Seemann <notifications@github.com> Fri, 12 April 2019 09:37 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A93021201DD for <quic-issues@ietfa.amsl.com>; Fri, 12 Apr 2019 02:37:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.383
X-Spam-Level:
X-Spam-Status: No, score=-6.383 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_24=1.618, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DamrPevqyBKE for <quic-issues@ietfa.amsl.com>; Fri, 12 Apr 2019 02:36:59 -0700 (PDT)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 5CE981201E6 for <quic-issues@ietf.org>; Fri, 12 Apr 2019 02:36:58 -0700 (PDT)
Date: Fri, 12 Apr 2019 02:36:57 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1555061817; bh=PSYciD8HQo+6Yw/Tv3DrgdN1gC+DPWesJ9/CqMEssAo=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=PAsRkpu+XU6O7dzLu94mrIT56P6RZ3781qZTatmZwKm2jqgZ0YMa2FN/v7BNDeHg3 ZZ/USzbclN3KR1dUaQjicGeYueTWOCAhRsKdCLWyD/BDvxp5i5cpBjVqNKDCTOG/io N/GpXfkan9xztpF443/RrZuki7dwCaxW/4aAxHLs=
From: Marten Seemann <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab27d1cdc4ebaf1e88c0137157f209d6bd11ed1c8f92cebabd8eb892a169ce19c6eb0a@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/issues/2611/482508794@github.com>
In-Reply-To: <quicwg/base-drafts/issues/2611@github.com>
References: <quicwg/base-drafts/issues/2611@github.com>
Subject: Re: [quicwg/base-drafts] lost_pn can go negative (#2611)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5cb05c38f3938_69203fda054d45bc49943e"; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: marten-seemann
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/UXViH3lQCR0C5lEyrh9H5EH945w>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Apr 2019 09:37:01 -0000

I support this proposal, since the way we’re initializing largest_acked_packet is wrong: we’re initializing it to 0, although we decided that 0 is a valid packet number.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/issues/2611#issuecomment-482508794