Re: [quicwg/base-drafts] Implicit acknowledgment via header block acknowledgment (#1399)
Martin Thomson <notifications@github.com> Thu, 31 May 2018 01:30 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 14BB612EA58 for <quic-issues@ietfa.amsl.com>; Wed, 30 May 2018 18:30:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gXxw-U6IARm3 for <quic-issues@ietfa.amsl.com>; Wed, 30 May 2018 18:30:51 -0700 (PDT)
Received: from out-7.smtp.github.com (out-7.smtp.github.com [192.30.252.198]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 6004E12EAA6 for <quic-issues@ietf.org>; Wed, 30 May 2018 18:30:51 -0700 (PDT)
Date: Wed, 30 May 2018 18:30:50 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1527730250; bh=aDZpmiu2fl9yRAj/kJKOVjmftdK1tbh0mP3k1hK9U34=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=b34RvUd0H9sFmhbNaoGVUt8d2yGiuJQQsSXh4RkQ9+pvlbc3uzGQne+VFIB7ukXVY 2ykdecpSbI/2M/RjNbgp6sXukeXH2zfMTCuPbotH0E0jnCRVHcC8Pz+nc8L7gHMrCH /bussCjDL359J40xi3fDaiQVi6q1gtGo/KQCdDls=
From: Martin Thomson <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4ab638b2c4e1a96351ba3d86022d482a024b2a2498c92cf000000011727124a92a169ce13860808@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1399/review/124646276@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1399@github.com>
References: <quicwg/base-drafts/pull/1399@github.com>
Subject: Re: [quicwg/base-drafts] Implicit acknowledgment via header block acknowledgment (#1399)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b0f504a8203f_4a3b2ad79444ef5823221"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: martinthomson
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Ud-ZVNUuc57duDJTRncdn9KjZlc>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.22
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 31 May 2018 01:30:53 -0000
martinthomson commented on this pull request.
> @@ -523,6 +530,12 @@ blocks within a stream have been fully processed.
~~~~~~~~~~
{:#fig-header-ack title="Header Acknowledgement"}
+An encoder MUST treat receipt of a Header Acknowledgment as also acknowledging
+any dynamic table entries that the header block referenced. That is, this
+instruction is also processed as a Table Size Synchronize instruction with a
+value matching the Largest Reference of the corresponding header block.
Damn, really? That's more efficient, I agree, but I completely missed that. (My fault, not the spec.) Since these are on the same stream, I think that we can make TSS incremental and avoid having two counters.
Now I have to fix my code...
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1399#discussion_r191968112
- Re: [quicwg/base-drafts] Implicit acknowledgment … afrind
- Re: [quicwg/base-drafts] Implicit acknowledgment … Martin Thomson
- Re: [quicwg/base-drafts] Implicit acknowledgment … Martin Thomson
- Re: [quicwg/base-drafts] Implicit acknowledgment … afrind
- [quicwg/base-drafts] Implicit acknowledgment via … Martin Thomson
- Re: [quicwg/base-drafts] Implicit acknowledgment … Mike Bishop
- Re: [quicwg/base-drafts] Implicit acknowledgment … Martin Thomson
- Re: [quicwg/base-drafts] Implicit acknowledgment … afrind
- Re: [quicwg/base-drafts] Implicit acknowledgment … Martin Thomson
- Re: [quicwg/base-drafts] Implicit acknowledgment … Martin Thomson
- Re: [quicwg/base-drafts] Implicit acknowledgment … Mike Bishop
- Re: [quicwg/base-drafts] Implicit acknowledgment … Mike Bishop
- Re: [quicwg/base-drafts] Implicit acknowledgment … Martin Thomson
- Re: [quicwg/base-drafts] Implicit acknowledgment … Martin Thomson