Re: [quicwg/base-drafts] Minor editorial fixes. (#1656)
Mike Bishop <notifications@github.com> Mon, 13 August 2018 17:49 UTC
Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 79D9C130E01 for <quic-issues@ietfa.amsl.com>; Mon, 13 Aug 2018 10:49:53 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.009
X-Spam-Level:
X-Spam-Status: No, score=-8.009 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001, T_DKIMWL_WL_HIGH=-0.01, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mJp8xEtKEeQK for <quic-issues@ietfa.amsl.com>; Mon, 13 Aug 2018 10:49:50 -0700 (PDT)
Received: from out-1.smtp.github.com (out-1.smtp.github.com [192.30.252.192]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id AB8AF130E08 for <quic-issues@ietf.org>; Mon, 13 Aug 2018 10:49:50 -0700 (PDT)
Date: Mon, 13 Aug 2018 10:49:49 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1534182589; bh=AY4qgd4gTHQtUHluO2cxyUHbRV3o9IUalMZhOopQd6I=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=QtOICsHOX0OnAJVvGu/YGkaDMsQAtRjIJf6/KHZtAD4vGJnmiNwx1qalV9oU2j6/7 N0XMmya7p0sBZBKwwByrMxW8YTJxLSx/HD5wmTNqjvkfZlTubFscPxfK1+rcxUsjs+ rrfH/WXGLXxAMsfXRu/eCUxGQurWAzCUDuXW0y0M=
From: Mike Bishop <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abeb0234fd0b4accb62df28fcdcb33ed14f8a3ab0992cf00000001178986bd92a169ce14de742b@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1656/review/145763666@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1656@github.com>
References: <quicwg/base-drafts/pull/1656@github.com>
Subject: Re: [quicwg/base-drafts] Minor editorial fixes. (#1656)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5b71c4bd97ee5_14703f8e0fad45bc6775f"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: MikeBishop
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Unol3jwbvmJtRDLBdQgN0566WQg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.27
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Aug 2018 17:49:54 -0000
MikeBishop approved this pull request. All good clean-ups. Thanks! > @@ -261,7 +261,7 @@ immediately. A stream becomes unblocked when the greatest absolute index in the dynamic table becomes greater than or equal to the Largest Reference for all header blocks the decoder has started reading from the stream. If a decoder encounters a header block where the actual largest reference is not equal to the -largest reference declared in the prefix, it MAY treat this as a stream error of +Largest Reference declared in the prefix, it MAY treat this as a stream error of I could go either way on this one.... I tend to view it similar to when `-transport` capitalizes "[Cc]onnection ID" -- "Largest Reference" is the field itself, while "the largest reference" means the greatest index referenced by the frame. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/quicwg/base-drafts/pull/1656#pullrequestreview-145763666