IETF Logo Mail Archive

Re: [quicwg/base-drafts] Rename Final Offset to Final Size (#2285)

Kazuho Oku <notifications@github.com> Thu, 03 January 2019 00:42 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C86FC12D4F1 for <quic-issues@ietfa.amsl.com>; Wed, 2 Jan 2019 16:42:38 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.064
X-Spam-Level:
X-Spam-Status: No, score=-8.064 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.065, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I0b-OuV-7a8J for <quic-issues@ietfa.amsl.com>; Wed, 2 Jan 2019 16:42:37 -0800 (PST)
Received: from out-4.smtp.github.com (out-4.smtp.github.com [192.30.252.195]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 048AC12D4EB for <quic-issues@ietf.org>; Wed, 2 Jan 2019 16:42:37 -0800 (PST)
Date: Wed, 02 Jan 2019 16:42:36 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1546476156; bh=C3NTAqBMKTAK3HjRjzOowLQIB7hBTAiLoYUWFN7sgqI=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=QXqW4qWfAcSnerZAoyhOQwSV6kF7bqhuErn0u0wLz4wt9NYxJ3x2qJ0ZUc3h4/mnE 2Kl5r4oQJkt2z3ysN91iDovpGZ9CFbDxixKJngQaAFMmV23wPuLqeqhFLoocN5ctdz X4W1TE/0eW3MTW0/F9JRH5DbiypQZ9nUOZ4VN6zY=
From: Kazuho Oku <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abd1371d4dd698c0fbed48f9428f751a065d102daf92cf0000000118451c7c92a169ce1791b3a4@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/2285/review/188877667@github.com>
In-Reply-To: <quicwg/base-drafts/pull/2285@github.com>
References: <quicwg/base-drafts/pull/2285@github.com>
Subject: Re: [quicwg/base-drafts] Rename Final Offset to Final Size (#2285)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5c2d5a7c360ee_505a3fb3e80d45b8114895"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: kazuho
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/UoyEczrqbYbuMATIxfEvdu3F9vg>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Jan 2019 00:42:39 -0000

kazuho commented on this pull request.



>  
-The final offset is the count of the number of bytes that are transmitted on a
-stream.  For a stream that is reset, the final offset is carried explicitly in a
-RESET_STREAM frame.  Otherwise, the final offset is the offset of the end of the
-data carried in a STREAM frame marked with a FIN flag, or 0 in the case of
-incoming unidirectional streams.
+The final size is the amount of data that is transmitted on a stream.  For a
+stream that is reset, the final size is carried explicitly in a RESET_STREAM
+frame.  Otherwise, the final size is the offset plus the length of a STREAM
+frame marked with a FIN flag, or 0 in the case of incoming unidirectional
+streams.

I think that the current draft is incorrectly referring to incoming unidirectional streams; see #2286.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/2285#pullrequestreview-188877667

v2.23.0 | Report a Bug | By Email