Re: [quicwg/base-drafts] What packet information to track and send (#1939)

Nick Banks <notifications@github.com> Wed, 31 October 2018 13:45 UTC

Return-Path: <noreply@github.com>
X-Original-To: quic-issues@ietfa.amsl.com
Delivered-To: quic-issues@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id DF384130E27 for <quic-issues@ietfa.amsl.com>; Wed, 31 Oct 2018 06:45:56 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -8.47
X-Spam-Level:
X-Spam-Status: No, score=-8.47 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.47, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_HI=-5, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=github.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UflPV40HRmWV for <quic-issues@ietfa.amsl.com>; Wed, 31 Oct 2018 06:45:55 -0700 (PDT)
Received: from out-3.smtp.github.com (out-3.smtp.github.com [192.30.252.194]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id E9568129385 for <quic-issues@ietf.org>; Wed, 31 Oct 2018 06:45:54 -0700 (PDT)
Date: Wed, 31 Oct 2018 06:45:53 -0700
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1540993553; bh=4msiylDbquNJ62Xpy1TcdD6jn1CgxutvOfhxau2iRV8=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=ziRvooNJzZnFG7GLz2UycFSxeA9LH3yQsZKdsP/CIyFvDA22cYKOKAAcBr70AWi41 MFkvbC3lRObQMUYVq7EXGzI5LtoZ2Y2YT7Ps492S8vLQYKvLnd+d2fkPPk8/4qIxFU OZBYPXTLhHLICpY4J6/OAKq32HAZ0xjIKy6vw8Uo=
From: Nick Banks <notifications@github.com>
Reply-To: quicwg/base-drafts <reply+0166e4abe1c4acb8c6963930f3245b613e28c75847d05cb892cf0000000117f1741192a169ce1665d8f7@reply.github.com>
To: quicwg/base-drafts <base-drafts@noreply.github.com>
Cc: Subscribed <subscribed@noreply.github.com>
Message-ID: <quicwg/base-drafts/pull/1939/review/170257698@github.com>
In-Reply-To: <quicwg/base-drafts/pull/1939@github.com>
References: <quicwg/base-drafts/pull/1939@github.com>
Subject: Re: [quicwg/base-drafts] What packet information to track and send (#1939)
Mime-Version: 1.0
Content-Type: multipart/alternative; boundary="--==_mimepart_5bd9b211ed81b_2d343fe64d4d45b8131923"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: nibanks
X-GitHub-Recipient: quic-issues
X-GitHub-Reason: subscribed
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: quic-issues@ietf.org
Archived-At: <https://mailarchive.ietf.org/arch/msg/quic-issues/Uv5uZ4P82JN3ruB4_H9VGyb4u_M>
X-BeenThere: quic-issues@ietf.org
X-Mailman-Version: 2.1.29
List-Id: Notification list for GitHub issues related to the QUIC WG <quic-issues.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/quic-issues/>
List-Post: <mailto:quic-issues@ietf.org>
List-Help: <mailto:quic-issues-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/quic-issues>, <mailto:quic-issues-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Oct 2018 13:45:57 -0000

nibanks approved this pull request.

LGTM 👍

> -  retransmittable. If true, it is expected that an acknowledgement will
-  be received, though the peer could delay sending the ACK frame containing
-  it by up to the MaxAckDelay.
-
-* in_flight: A boolean that indicates whether the packet counts towards bytes in
-  flight.
-
-* is_crypto_packet: A boolean that indicates whether the packet contains
-  cryptographic handshake messages critical to the completion of the QUIC
-  handshake. In this version of QUIC, this includes any packet with the long
-  header that includes a CRYPTO frame.
-
-* sent_bytes: The number of bytes sent in the packet, not including UDP or IP
-  overhead, but including QUIC framing overhead.
+After any packet is sent.  The parameters to OnPacketSent are described in detail
+above in {{sent-packets-fields}}.

I believe the error is because `detail` needs to wrap to the next line.
```
After any packet is sent.  The parameters to OnPacketSent are described in
detail above in {{sent-packets-fields}}.
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/quicwg/base-drafts/pull/1939#pullrequestreview-170257698